Merge pull request #686 from chmouel/allow-localhost

gitea fixes

Author: Shivam Mukhade

docs/content/dev/_index.md

@@ -91,7 +91,6 @@ spec:
     webhook_secret:
       name: "secret"
       key: "webhook"
-
 ---
 apiVersion: v1
 kind: Secret
@@ -108,6 +107,7 @@ There is some gotchas with the webhook validation secret, Pipelines as Code
 detect a Gitea install and let the user set a empty webhook secret (by default
 it's enforced).
 
+Gitops comment like `/retest` or `/ok-to-test` is not working at the moment.
 Other than that YMMV, feel free to raise a bug if you find some.
 
 ## Debugging controller

pkg/provider/github/events.go

@@ -49,7 +49,7 @@ func (v *Provider) getAppToken(ctx context.Context, kube kubernetes.Interface, g
 	}
 
 	if gheURL != "" {
-		if !strings.HasPrefix(gheURL, "https://") {
+		if !strings.HasPrefix(gheURL, "https://") && !strings.HasPrefix(gheURL, "http://") {
 			gheURL = "https://" + gheURL
 		}
 		v.Client, _ = github.NewEnterpriseClient(gheURL, "", &http.Client{Transport: itr})

pkg/provider/github/github.go

@@ -99,7 +99,7 @@ func (v *Provider) SetClient(ctx context.Context, event *info.Event) error {
 	var client *github.Client
 	apiURL := event.Provider.URL
 	if apiURL != "" {
-		if !strings.HasPrefix(apiURL, "https") {
+		if !strings.HasPrefix(apiURL, "https") && !strings.HasPrefix(apiURL, "http") {
 			apiURL = "https://" + apiURL
 		}
 	}
@@ -328,7 +328,7 @@ func (v *Provider) Detect(reqHeader *http.Header, payload string, logger *zap.Su
 		return setLoggerAndProceed(false, "push: no pusher in event", nil)
 
 	case *github.PullRequestEvent:
-		if provider.Valid(gitEvent.GetAction(), []string{"opened", "synchronize", "reopened"}) {
+		if provider.Valid(gitEvent.GetAction(), []string{"opened", "synchronize", "synchronized", "reopened"}) {
 			return setLoggerAndProceed(true, "", nil)
 		}
 		return setLoggerAndProceed(false, fmt.Sprintf("pull_request: unsupported action \"%s\"", gitEvent.GetAction()), nil)