[status] Fix PR status when no tasks has run

When no task has started (ie: bad pr spec) we were showing the raw template.
The test as well was buggy since we were testing for that raw template
🤮, I am not sure how I came to that point but such is life.

We are now showing properly that no tasks has been detecred since PR has
not been run.

Closes #414

Signed-off-by: Chmouel Boudjnah <[email protected]>

Author: chmouel

pkg/pipelineascode/pipelinesascode_github_test.go

@@ -135,7 +135,7 @@ func TestRun(t *testing.T) {
 		ProviderInfoFromRepo         bool
 	}{
 		{
-			name: "pull request/apps",
+			name: "pull request/fail-to-start-apps",
 			runevent: info.Event{
 				SHA:          "principale",
 				Organization: "organizationes",
@@ -148,7 +148,7 @@ func TestRun(t *testing.T) {
 			},
 			tektondir:       "testdata/pull_request",
 			finalStatus:     "neutral",
-			finalStatusText: "<th>Status</th><th>Duration</th><th>Name</th>",
+			finalStatusText: "PipelineRun has failed to start",
 		},
 		{
 			name: "pull request/with webhook",
@@ -295,7 +295,7 @@ func TestRun(t *testing.T) {
 			},
 			tektondir:                "testdata/max-keep-runs",
 			finalStatus:              "neutral",
-			finalStatusText:          "<th>Status</th><th>Duration</th><th>Name</th>",
+			finalStatusText:          "PipelineRun has failed to start",
 			expectedNumberofCleanups: 10,
 		},
 	}

pkg/sort/task_status.go

@@ -42,8 +42,7 @@ func TaskStatusTmpl(pr *tektonv1beta1.PipelineRun, console consoleui.Interface,
 	outputBuffer := bytes.Buffer{}
 
 	if len(pr.Status.TaskRuns) == 0 {
-		// Nada?
-		return statusTemplate + "No tasks has been found", nil
+		return "<b>PipelineRun has failed to start</b><br>", nil
 	}
 
 	for _, taskrunStatus := range pr.Status.TaskRuns {

pkg/sort/task_status_test.go

@@ -52,7 +52,7 @@ func TestStatusTmpl(t *testing.T) {
 		},
 		{
 			name:       "test sorted status nada",
-			wantRegexp: regexp.MustCompile("No tasks has been found"),
+			wantRegexp: regexp.MustCompile("PipelineRun has failed to start"),
 			pr:         tektontest.MakePR("nada", "ns", nil, nil),
 		},
 	}