fix(ci): use exec.CommandContext to satisfy noctx linter

Replaced all direct calls to exec.Command with the context-aware
exec.CommandContext across CLI utilities and helper packages.

Signed-off-by: Zaki Shaikh <[email protected]>

Author: zakisk

pkg/cli/browser/browser.go

@@ -1,12 +1,13 @@
 package browser
 
 import (
+	"context"
 	"os/exec"
 	"runtime"
 )
 
 // OpenWebBrowser opens the specified URL in the default browser of the user.
-func OpenWebBrowser(url string) error {
+func OpenWebBrowser(ctx context.Context, url string) error {
 	var cmd string
 
 	args := []string{}
@@ -21,5 +22,5 @@ func OpenWebBrowser(url string) error {
 	}
 
 	args = append(args, url)
-	return exec.Command(cmd, args...).Start()
+	return exec.CommandContext(ctx, cmd, args...).Start()
 }

pkg/cmd/tknpac/bootstrap/install.go

@@ -48,12 +48,12 @@ func getLatestRelease(ctx context.Context, k8release string) (string, string, er
 }
 
 // kubectlApply get kubectl binary and apply a yaml file.
-func kubectlApply(uri string) error {
+func kubectlApply(ctx context.Context, uri string) error {
 	path, err := exec.LookPath("kubectl")
 	if err != nil {
 		return err
 	}
-	cmd := exec.Command(path, "apply", "-f", uri)
+	cmd := exec.CommandContext(ctx, path, "apply", "-f", uri)
 	out, err := cmd.CombinedOutput()
 	if err != nil {
 		return fmt.Errorf("%w\n%s", err, out)
@@ -112,7 +112,7 @@ func getDashboardURL(ctx context.Context, opts *bootstrapOpts, run *params.Run)
 }
 
 // installGosmeeForwarder Install a gosmee forwarded to hook.pipelinesascode.com.
-func installGosmeeForwarder(opts *bootstrapOpts) error {
+func installGosmeeForwarder(ctx context.Context, opts *bootstrapOpts) error {
 	gosmeInstall, err := askYN(true, fmt.Sprintf(gosmeeInstallHelpText, opts.forwarderURL), "Do you want me to install the gosmee forwarder?", opts.ioStreams.Out)
 	if err != nil {
 		return err
@@ -132,7 +132,7 @@ func installGosmeeForwarder(opts *bootstrapOpts) error {
 	if _, err = f.WriteString(tmpl); err != nil {
 		return err
 	}
-	if err := kubectlApply(f.Name()); err != nil {
+	if err := kubectlApply(ctx, f.Name()); err != nil {
 		return err
 	}
 	fmt.Fprintf(opts.ioStreams.Out, "💡 Your gosmee forward URL has been generated: %s\n", opts.RouteName)
@@ -175,14 +175,14 @@ func installPac(ctx context.Context, run *params.Run, opts *bootstrapOpts) error
 		}
 	}
 
-	if err := kubectlApply(latestReleaseYaml); err != nil {
+	if err := kubectlApply(ctx, latestReleaseYaml); err != nil {
 		return err
 	}
 
 	fmt.Fprintf(opts.ioStreams.Out, "✓ Pipelines-as-Code %s has been installed\n", latestVersion)
 
 	if (!isOpenShift && opts.RouteName == "") || opts.forceInstallGosmee {
-		if err := installGosmeeForwarder(opts); err != nil {
+		if err := installGosmeeForwarder(ctx, opts); err != nil {
 			return err
 		}
 	}

pkg/cmd/tknpac/bootstrap/web.go

@@ -45,7 +45,7 @@ func startWebServer(ctx context.Context, opts *bootstrapOpts, run *params.Run, j
 		url := fmt.Sprintf("http://localhost:%d", opts.webserverPort)
 		fmt.Fprintf(opts.ioStreams.Out, "🌍 Starting a web browser on %s, click on the button to create your GitHub APP\n", url)
 		//nolint:errcheck
-		go browser.OpenWebBrowser(url)
+		go browser.OpenWebBrowser(ctx, url)
 		if err := s.ListenAndServe(); err != nil && !errors.Is(err, http.ErrServerClosed) {
 			log.Fatal(err)
 		}

pkg/cmd/tknpac/completion/completion.go

@@ -1,6 +1,7 @@
 package completion
 
 import (
+	"context"
 	"os/exec"
 	"strings"
 
@@ -10,7 +11,7 @@ import (
 // GetObjectsWithKubectl return completions with kubectl, we are doing this with
 // kubectl since we have caching and without it completion is way too slow.
 func GetObjectsWithKubectl(obj string) []string {
-	out, err := exec.Command("kubectl", "get", obj, "-o=jsonpath={range .items[*]}{.metadata.name} {end}").Output()
+	out, err := exec.CommandContext(context.Background(), "kubectl", "get", obj, "-o=jsonpath={range .items[*]}{.metadata.name} {end}").Output()
 	if err != nil {
 		return nil
 	}

pkg/cmd/tknpac/logs/logs.go

@@ -238,12 +238,12 @@ func log(ctx context.Context, lo *logOption) error {
 	replyName := strings.Fields(replyString)[0]
 
 	if lo.webBrowser {
-		return showLogsWithWebConsole(lo, replyName)
+		return showLogsWithWebConsole(ctx, lo, replyName)
 	}
 	return showlogswithtkn(lo.tknPath, replyName, lo.cs.Info.Kube.Namespace)
 }
 
-func showLogsWithWebConsole(lo *logOption, pr string) error {
+func showLogsWithWebConsole(ctx context.Context, lo *logOption, pr string) error {
 	if os.Getenv("PAC_TEKTON_DASHBOARD_URL") != "" {
 		lo.cs.Clients.SetConsoleUI(&consoleui.TektonDashboard{BaseURL: os.Getenv("PAC_TEKTON_DASHBOARD_URL")})
 	}
@@ -254,7 +254,7 @@ func showLogsWithWebConsole(lo *logOption, pr string) error {
 			Namespace: lo.cs.Info.Kube.Namespace,
 		},
 	}
-	return browser.OpenWebBrowser(lo.cs.Clients.ConsoleUI().DetailURL(prObj))
+	return browser.OpenWebBrowser(ctx, lo.cs.Clients.ConsoleUI().DetailURL(prObj))
 }
 
 func showlogswithtkn(tknPath, pr, ns string) error {

pkg/git/git.go

@@ -2,6 +2,7 @@ package git
 
 import (
 	"bytes"
+	"context"
 	"fmt"
 	"os"
 	"os/exec"
@@ -24,7 +25,7 @@ func RunGit(dir string, args ...string) (string, error) {
 	// insert in args "-c", "gitcommit.gpgsign=false" at the beginning gpg sign when set in user
 	args = append([]string{"-c", "commit.gpgsign=false"}, args...)
 
-	c := exec.Command(gitPath, args...)
+	c := exec.CommandContext(context.Background(), gitPath, args...)
 	c.Env = []string{
 		"PATH=" + os.Getenv("PATH"),
 		"HOME=" + os.Getenv("HOME"),