fix(github): change skip log level from error to info

When a push event is skipped because the commit is part of an
open pull request, PAC was logging this intentional skip at
ERROR level.
This caused confusion for users and support teams.
This PR fixes error to info-level logging for intentional push event skips.

Signed-off-by: Shubham Bhardwaj <[email protected]>
Co-authored-by: Chmouel Boudjnah <[email protected]>

Author: infernus01

pkg/adapter/sinker.go

@@ -32,6 +32,10 @@ func (s *sinker) processEventPayload(ctx context.Context, request *http.Request)
 		s.logger.Errorf("failed to parse event: %v", err)
 		return err
 	}
+	// If ParsePayload returned nil event (intentional skip), exit early
+	if s.event == nil {
+		return nil
+	}
 
 	// Enhanced structured logging with source repository context for operators
 	logFields := []interface{}{
@@ -69,6 +73,9 @@ func (s *sinker) processEvent(ctx context.Context, request *http.Request) error
 		if err := s.processEventPayload(ctx, request); err != nil {
 			return err
 		}
+		if s.event == nil {
+			return nil
+		}
 	}
 
 	p := pipelineascode.NewPacs(s.event, s.vcx, s.run, s.pacInfo, s.kint, s.logger, s.globalRepo)

pkg/provider/github/github_test.go

@@ -1518,8 +1518,8 @@ func TestSkipPushEventForPRCommits(t *testing.T) {
 				},
 			},
 			isPartOfPR:      true,
-			wantErr:         true,
-			wantErrContains: "commit abc123 is part of pull request #42, skipping push event",
+			wantErr:         false,
+			wantErrContains: "",
 		},
 		{
 			name:           "continue processing push event when commit is not part of PR",
@@ -1645,15 +1645,20 @@ func TestSkipPushEventForPRCommits(t *testing.T) {
 
 			// If no error expected, check the result
 			assert.NilError(t, err)
+
+			// If push event was skipped (commit is part of PR), result should be nil
+			if tt.pacInfoEnabled && tt.isPartOfPR {
+				assert.Assert(t, result == nil, "Expected nil result when push event is skipped for PR commit")
+				return
+			}
+
 			assert.Assert(t, result != nil, "Expected non-nil result when no error occurs")
 
 			// Check event fields were properly processed
-			if !tt.pacInfoEnabled || !tt.isPartOfPR {
-				assert.Equal(t, result.Organization, tt.pushEvent.GetRepo().GetOwner().GetLogin())
-				assert.Equal(t, result.Repository, tt.pushEvent.GetRepo().GetName())
-				assert.Equal(t, result.SHA, tt.pushEvent.GetHeadCommit().GetID())
-				assert.Equal(t, result.Sender, tt.pushEvent.GetSender().GetLogin())
-			}
+			assert.Equal(t, result.Organization, tt.pushEvent.GetRepo().GetOwner().GetLogin())
+			assert.Equal(t, result.Repository, tt.pushEvent.GetRepo().GetName())
+			assert.Equal(t, result.SHA, tt.pushEvent.GetHeadCommit().GetID())
+			assert.Equal(t, result.Sender, tt.pushEvent.GetSender().GetLogin())
 
 			// Check for warning logs if applicable
 			if tt.skipWarnLogContains != "" {

pkg/provider/github/parse_payload.go

@@ -178,6 +178,10 @@ func (v *Provider) ParsePayload(ctx context.Context, run *params.Run, request *h
 		return nil, err
 	}
 
+	if processedEvent == nil {
+		return nil, nil
+	}
+
 	processedEvent.Event = eventInt
 	processedEvent.InstallationID = installationIDFrompayload
 	processedEvent.GHEURL = event.Provider.URL
@@ -359,7 +363,7 @@ func (v *Provider) processEvent(ctx context.Context, event *info.Event, eventInt
 			// If the commit is part of a PR, skip processing the push event
 			if isPartOfPR {
 				v.Logger.Infof("Skipping push event for commit %s as it belongs to pull request #%d", sha, prNumber)
-				return nil, fmt.Errorf("commit %s is part of pull request #%d, skipping push event", sha, prNumber)
+				return nil, nil
 			}
 		}
 

pkg/provider/github/parse_payload_test.go

@@ -923,10 +923,10 @@ func TestParsePayLoad(t *testing.T) {
 				},
 				HeadCommit: &github.HeadCommit{ID: github.Ptr("SHAPush")},
 			},
-			shaRet:                    "SHAPush",
+			shaRet:                    "",
 			skipPushEventForPRCommits: true,
 			muxReplies:                map[string]any{"/repos/owner/pushRepo/commits/SHAPush/pulls": sampleGhPRs},
-			wantErrString:             "commit SHAPush is part of pull request #42, skipping push event",
+			wantErrString:             "",
 		},
 		{
 			name:          "good/skip tag push event for skip-pr-commits setting",
@@ -1035,6 +1035,12 @@ func TestParsePayLoad(t *testing.T) {
 				return
 			}
 			assert.NilError(t, err)
+			// If shaRet is empty, this is a skip case (push event for PR commit)
+			// In this case, ret should be nil
+			if tt.shaRet == "" {
+				assert.Assert(t, ret == nil, "Expected nil result for skipped push event")
+				return
+			}
 			assert.Assert(t, ret != nil)
 			assert.Equal(t, tt.shaRet, ret.SHA)
 			if tt.eventType == triggertype.PullRequest.String() {

test/github_pullrequest_test.go

@@ -614,7 +614,7 @@ func TestGithubPullandPushMatchTriggerOnlyPull(t *testing.T) {
 	assert.NilError(t, err)
 	ctx = info.StoreNS(ctx, globalNs)
 
-	reg := regexp.MustCompile(fmt.Sprintf("commit.*is part of pull request #%d.*skipping push event", g.PRNumber))
+	reg := regexp.MustCompile(fmt.Sprintf("Skipping push event for commit.*as it belongs to pull request #%d", g.PRNumber))
 	maxLines := int64(100)
 	err = twait.RegexpMatchingInControllerLog(ctx, g.Cnx, *reg, 20, "controller", &maxLines)
 	assert.NilError(t, err)