Don't show the secret content if we cannot create the secret

chmouel · chmouel · commit 69a6a2d86182 · 2023-04-19T10:39:15.000+02:00
Fixes #1238
diff --git a/pkg/pipelineascode/pipelineascode.go b/pkg/pipelineascode/pipelineascode.go
@@ -120,7 +120,7 @@ func (p *PacRun) startPR(ctx context.Context, match matcher.Match) (*v1beta1.Pip
 		}
 
 		if err = p.k8int.CreateSecret(ctx, match.Repo.GetNamespace(), authSecret); err != nil {
-			return nil, fmt.Errorf("creating basic auth secret: %s has failed: %w ", gitAuthSecretName, err)
+			return nil, fmt.Errorf("creating basic auth secret: %s has failed: %w ", authSecret.GetName(), err)
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ func (p PacRun) startPR(ctx context.Context, match matcher.Match) (v1beta1.Pip`
`120`	`120`	`}`
`121`	`121`
`122`	`122`	`if err = p.k8int.CreateSecret(ctx, match.Repo.GetNamespace(), authSecret); err != nil {`
`123`		`- return nil, fmt.Errorf("creating basic auth secret: %s has failed: %w ", gitAuthSecretName, err)`
	`123`	`+ return nil, fmt.Errorf("creating basic auth secret: %s has failed: %w ", authSecret.GetName(), err)`
`124`	`124`	`}`
`125`	`125`	`}`
`126`	`126`