Make sure we skip clustertasks

Signed-off-by: Chmouel Boudjnah <[email protected]>

Author: chmouel

pkg/resolve/resolve.go

@@ -81,7 +81,9 @@ func inlineTasks(tasks []tektonv1beta1.PipelineTask, ropt *Opts, types Types) ([
 	error) {
 	pipelineTasks := []tektonv1beta1.PipelineTask{}
 	for _, task := range tasks {
-		if task.TaskRef != nil && task.TaskRef.Bundle == "" && !skippingTask(task.TaskRef.Name, ropt.SkipInlining) {
+		if task.TaskRef != nil && task.TaskRef.Bundle == "" &&
+			string(task.TaskRef.Kind) != "ClusterTask" &&
+			!skippingTask(task.TaskRef.Name, ropt.SkipInlining) {
 			taskResolved, err := getTaskByName(task.TaskRef.Name, types.Tasks)
 			if err != nil {
 				return nil, err

pkg/resolve/resolve_test.go

@@ -85,6 +85,13 @@ func TestBundlesSkipped(t *testing.T) {
 	assert.Equal(t, resolved.Spec.PipelineSpec.Tasks[0].TaskRef.Bundle, "reg.io/ruben/barichello@sha256:1234")
 }
 
+func TestClusterTasksSkipped(t *testing.T) {
+	resolved, _, err := readTDfile(t, "pipelinerun-with-a-clustertasks", false)
+	assert.NilError(t, err)
+	assert.Equal(t, resolved.Spec.PipelineSpec.Tasks[0].Name, "clustertask")
+	assert.Equal(t, string(resolved.Spec.PipelineSpec.Tasks[0].TaskRef.Kind), "ClusterTask")
+}
+
 func TestPipelineRunPipelineSpecTaskSpec(t *testing.T) {
 	resolved, _, err := readTDfile(t, "pipelinerun-pipelinespec-taskspec", false)
 	assert.NilError(t, err)

pkg/resolve/testdata/pipelinerun-with-a-clustertasks.yaml

@@ -0,0 +1,28 @@
+---
+apiVersion: tekton.dev/v1beta1
+kind: PipelineRun
+metadata:
+  name: pr-test1
+spec:
+  pipelineRef:
+    name: pipeline-test1
+  params:
+    - name: key
+      value: "{{value}}"
+---
+apiVersion: tekton.dev/v1beta1
+kind: Pipeline
+metadata:
+  name: pipeline-test1
+spec:
+  params:
+    - name: repo_url
+    - name: revision
+  tasks:
+    - name: clustertask
+      taskRef:
+        name: foo
+        kind: ClusterTask
+  steps:
+    - name: first-step
+      image: image