fix: Improve handling of missing .tekton directory for ok-to-test events

Update getPipelineRunsFromRepo to create a neutral status with
specific messaging when .tekton directory is missing during
ok-to-test events, clarifying that the directory doesn't exist
in the repository's root.

Adjust error logging for push events to handle empty
rawTemplates case without creating comments, ensuring
consistent behavior across event types.

Modify unit tests in match_test.go to cover the new missing
.tekton directory scenario, including a new test case using
"testdata/no_tekton_dir" and removing unnecessary status
expectation fields for simplicity.

https://issues.redhat.com/browse/SRVKP-7680

Signed-off-by: Zaki Shaikh <[email protected]>

Author: zakisk

docs/content/docs/guide/gitops_commands.md

@@ -262,8 +262,7 @@ Here are the possible event types:
 * `cancel-comment`: The event is a `/cancel <PipelineRun>` that would cancel a specific PipelineRun.
 * `ok-to-test-comment`: The event is a `/ok-to-test` that would allow running the CI for an unauthorized user.
 
-When a repository owner issues the `/ok-to-test` command on a pull request raised by an unauthorized user, and no PipelineRun exists in the .tekton directory for `pull_request` event,
-Pipelines-as-Code will create a neutral check-run status. This status serves to indicate that no PipelineRun has been matched, preventing any workflows from being blocked such as auto-merge, will proceed as expected.
+If a repository owner comments `/ok-to-test` on a pull request from an external contributor but no PipelineRun **matches** the `pull_request` event (or the repository has no `.tekton` directory), Pipelines-as-Code sets a **neutral** commit status. This indicates that no PipelineRun was matched, allowing other workflows—such as auto-merge—to proceed without being blocked.
 
 {{< hint info >}}
 

pkg/pipelineascode/errors.go

@@ -13,11 +13,14 @@ import (
 	"go.uber.org/zap"
 )
 
-const validationErrorTemplate = `> [!CAUTION]
+const (
+	validationErrorTemplate = `> [!CAUTION]
 > There are some errors in your PipelineRun template.
 
 | PipelineRun | Error |
 |------|-------|`
+	tektonDirMissingError = ".tekton/ directory doesn't exist in repository's root directory"
+)
 
 var regexpIgnoreErrors = regexp.MustCompile(`.*no kind.*is registered for version.*in scheme.*`)
 

pkg/pipelineascode/match.go

@@ -196,6 +196,13 @@ func (p *PacRun) getPipelineRunsFromRepo(ctx context.Context, repo *v1alpha1.Rep
 		return nil, err
 	}
 
+	if rawTemplates == "" && p.event.EventType == opscomments.OkToTestCommentEventType.String() {
+		err = p.createNeutralStatus(ctx, ".tekton directory not found", tektonDirMissingError)
+		if err != nil {
+			p.eventEmitter.EmitMessage(nil, zap.ErrorLevel, "RepositoryCreateStatus", err.Error())
+		}
+	}
+
 	// This is for push event error logging because we can't create comment for yaml validation errors on push
 	if err != nil || rawTemplates == "" {
 		msg := ""
@@ -279,10 +286,12 @@ func (p *PacRun) getPipelineRunsFromRepo(ctx context.Context, repo *v1alpha1.Rep
 			// GitOps command `/ok-to-test` to trigger CI, but no matching pull request is found,
 			// a neutral check-run will be created on the pull request to indicate that no PipelineRun was triggered
 			if p.event.EventType == opscomments.OkToTestCommentEventType.String() && len(matchedPRs) == 0 {
-				err = p.createNeutralStatus(ctx)
+				text := fmt.Sprintf("No matching PipelineRun found for the '%s' event in .tekton/ directory. Please ensure that PipelineRun is configured for '%s' event.", p.event.TriggerTarget.String(), p.event.TriggerTarget.String())
+				err = p.createNeutralStatus(ctx, "No PipelineRun matched", text)
 				if err != nil {
 					p.eventEmitter.EmitMessage(nil, zap.WarnLevel, "RepositoryCreateStatus", err.Error())
 				}
+				p.eventEmitter.EmitMessage(nil, zap.InfoLevel, "RepositoryNoMatch", text)
 			}
 			return nil, nil
 		}
@@ -426,11 +435,11 @@ func (p *PacRun) checkNeedUpdate(_ string) (string, bool) {
 	return "", false
 }
 
-func (p *PacRun) createNeutralStatus(ctx context.Context) error {
+func (p *PacRun) createNeutralStatus(ctx context.Context, title, text string) error {
 	status := provider.StatusOpts{
 		Status:     CompletedStatus,
-		Title:      "No PipelineRun matched",
-		Text:       fmt.Sprintf("No matching PipelineRun found for the '%s' event in Pipelines as Code. Please ensure that PipelineRun is configured for '%s' event.", p.event.TriggerTarget.String(), p.event.TriggerTarget.String()),
+		Title:      title,
+		Text:       text,
 		Conclusion: neutralConclusion,
 		DetailsURL: p.event.URL,
 	}

pkg/pipelineascode/match_test.go

@@ -234,6 +234,19 @@ func TestGetPipelineRunsFromRepo(t *testing.T) {
 			expectedNumberOfPruns: 0,
 			event:                 okToTestEvent,
 		},
+		{
+			name: "no .tekton dir in repository",
+			repositories: &v1alpha1.Repository{
+				ObjectMeta: metav1.ObjectMeta{
+					Name:      "testrepo",
+					Namespace: "test",
+				},
+				Spec: v1alpha1.RepositorySpec{},
+			},
+			tektondir:             "testdata/no_tekton_dir",
+			expectedNumberOfPruns: 0,
+			event:                 okToTestEvent,
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {

pkg/pipelineascode/testdata/no_tekton_dir/.gitkeep

@@ -0,0 +1 @@
+we need this file in order to keep no_tekton_dir folder otherwise git ignores it.