Fix golangci-lint latest

Mostly unused variables of revive linter errors

Signed-off-by: Chmouel Boudjnah <[email protected]>

Author: chmouel

pkg/cli/cli.go

@@ -5,7 +5,6 @@ import (
 
 	"github.com/AlecAivazis/survey/v2"
 	"github.com/AlecAivazis/survey/v2/terminal"
-	"github.com/spf13/cobra"
 )
 
 type PacCliOpts struct {
@@ -26,7 +25,7 @@ func NewAskopts(opt *survey.AskOptions) error {
 	return nil
 }
 
-func NewCliOptions(cmd *cobra.Command) *PacCliOpts {
+func NewCliOptions() *PacCliOpts {
 	return &PacCliOpts{
 		AskOpts: NewAskopts,
 	}

pkg/cli/webhook/gitlab_test.go

@@ -84,8 +84,8 @@ func TestAskGLWebhookConfig(t *testing.T) {
 }
 
 func TestGLCreate(t *testing.T) {
-	ctx, _ := rtesting.SetupFakeContext(t)
-	fakeclient, mux, teardown := thelp.Setup(ctx, t)
+	_, _ = rtesting.SetupFakeContext(t)
+	fakeclient, mux, teardown := thelp.Setup(t)
 	defer teardown()
 	//nolint
 	io, _, _, _ := cli.IOTest()

pkg/cmd/tknpac/bootstrap/bootstrap.go

@@ -138,7 +138,7 @@ func Command(run *params.Run, ioStreams *cli.IOStreams) *cobra.Command {
 		Short: "Bootstrap Pipelines as Code.",
 		RunE: func(cmd *cobra.Command, args []string) error {
 			ctx := context.Background()
-			opts.cliOpts = cli.NewCliOptions(cmd)
+			opts.cliOpts = cli.NewCliOptions()
 			opts.ioStreams.SetColorEnabled(!opts.cliOpts.NoColoring)
 			if err := run.Clients.NewClients(ctx, &run.Info); err != nil {
 				return err
@@ -191,7 +191,7 @@ func GithubApp(run *params.Run, ioStreams *cli.IOStreams) *cobra.Command {
 		Short: "Create PAC GitHub Application",
 		RunE: func(cmd *cobra.Command, args []string) error {
 			ctx := context.Background()
-			opts.cliOpts = cli.NewCliOptions(cmd)
+			opts.cliOpts = cli.NewCliOptions()
 			opts.ioStreams.SetColorEnabled(!opts.cliOpts.NoColoring)
 			if err := run.Clients.NewClients(ctx, &run.Info); err != nil {
 				return err

pkg/cmd/tknpac/completion/completion.go

@@ -26,6 +26,6 @@ func BaseCompletion(target string, args []string) ([]string, cobra.ShellCompDire
 }
 
 // ParentCompletion do completion of command to the Parent
-func ParentCompletion(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
+func ParentCompletion(cmd *cobra.Command, args []string, _ string) ([]string, cobra.ShellCompDirective) {
 	return BaseCompletion(cmd.Parent().Name(), args)
 }

pkg/cmd/tknpac/create/repository.go

@@ -54,7 +54,7 @@ func repositoryCommand(run *params.Run, ioStreams *cli.IOStreams) *cobra.Command
 		RunE: func(cmd *cobra.Command, args []string) error {
 			ctx := context.Background()
 			createOpts.IoStreams = ioStreams
-			createOpts.cliOpts = cli.NewCliOptions(cmd)
+			createOpts.cliOpts = cli.NewCliOptions()
 			createOpts.IoStreams.SetColorEnabled(!createOpts.cliOpts.NoColoring)
 
 			cwd, err := os.Getwd()
@@ -83,10 +83,7 @@ func repositoryCommand(run *params.Run, ioStreams *cli.IOStreams) *cobra.Command
 
 			if pacInfo.IsGithubAppInstalled(ctx, run, installationNS) {
 				if strings.Contains(createOpts.Event.URL, "github") {
-					if err := createOpts.generateTemplate(nil); err != nil {
-						return err
-					}
-					return nil
+					return createOpts.generateTemplate(nil)
 				}
 			}
 
@@ -108,10 +105,7 @@ func repositoryCommand(run *params.Run, ioStreams *cli.IOStreams) *cobra.Command
 			if err := config.Install(ctx, createOpts.Provider); err != nil {
 				return err
 			}
-			if err := createOpts.generateTemplate(nil); err != nil {
-				return err
-			}
-			return nil
+			return createOpts.generateTemplate(nil)
 		},
 		Annotations: map[string]string{
 			"commandType": "main",

pkg/cmd/tknpac/deleterepo/delete.go

@@ -34,7 +34,7 @@ func repositoryCommand(run *params.Run, ioStreams *cli.IOStreams) *cobra.Command
 		},
 		RunE: func(cmd *cobra.Command, args []string) error {
 			var err error
-			opts := cli.NewCliOptions(cmd)
+			opts := cli.NewCliOptions()
 			opts.Namespace, err = cmd.Flags().GetString(namespaceFlag)
 			if err != nil {
 				return err

pkg/cmd/tknpac/describe/describe.go

@@ -63,9 +63,9 @@ type describeOpts struct {
 	ShowEvents        bool
 }
 
-func newDescribeOptions(cmd *cobra.Command) *describeOpts {
+func newDescribeOptions(_ *cobra.Command) *describeOpts {
 	return &describeOpts{
-		PacCliOpts: *cli.NewCliOptions(cmd),
+		PacCliOpts: *cli.NewCliOptions(),
 	}
 }
 

pkg/cmd/tknpac/generate/generate.go

@@ -59,7 +59,7 @@ func Command(run *params.Run, ioStreams *cli.IOStreams) *cobra.Command {
 		Short:   "Generate PipelineRun",
 		RunE: func(cmd *cobra.Command, args []string) error {
 			ctx := context.Background()
-			gopt.CLIOpts = cli.NewCliOptions(cmd)
+			gopt.CLIOpts = cli.NewCliOptions()
 			gopt.IOStreams.SetColorEnabled(!gopt.CLIOpts.NoColoring)
 
 			if !gopt.generateWithClusterTask {
@@ -113,10 +113,7 @@ func Generate(o *Opts, recreateTemplate bool) error {
 		return err
 	}
 
-	if err := o.samplePipeline(recreateTemplate); err != nil {
-		return err
-	}
-	return nil
+	return o.samplePipeline(recreateTemplate)
 }
 
 func (o *Opts) targetEvent() error {

pkg/cmd/tknpac/list/list.go

@@ -44,7 +44,7 @@ func Root(run *params.Run, ioStreams *cli.IOStreams) *cobra.Command {
 		},
 		RunE: func(cmd *cobra.Command, args []string) error {
 			var err error
-			opts := cli.NewCliOptions(cmd)
+			opts := cli.NewCliOptions()
 			opts.AllNameSpaces, err = cmd.Flags().GetBool(allNamespacesFlag)
 			if err != nil {
 				return err

pkg/cmd/tknpac/logs/logs.go

@@ -69,7 +69,7 @@ func Command(run *params.Run, ioStreams *cli.IOStreams) *cobra.Command {
 		RunE: func(cmd *cobra.Command, args []string) error {
 			var err error
 			var repoName string
-			opts := cli.NewCliOptions(cmd)
+			opts := cli.NewCliOptions()
 
 			opts.Namespace, err = cmd.Flags().GetString(namespaceFlag)
 			if err != nil {