Validate setting only if defined

if settings are not defined and we validate empty string it was
failing for tektondashboard url, but anyway we should validate
only if value is set.

Signed-off-by: Shivam Mukhade <[email protected]>

Author: Shivam Mukhade

pkg/params/settings/validation.go

@@ -7,19 +7,19 @@ import (
 )
 
 func Validate(config map[string]string) error {
-	if secretAutoCreation, ok := config[SecretAutoCreateKey]; ok {
+	if secretAutoCreation, ok := config[SecretAutoCreateKey]; ok && secretAutoCreation != "" {
 		if !isValidBool(secretAutoCreation) {
 			return fmt.Errorf("invalid value for key %v, acceptable values: true or false", SecretAutoCreateKey)
 		}
 	}
 
-	if remoteTask, ok := config[RemoteTasksKey]; ok {
+	if remoteTask, ok := config[RemoteTasksKey]; ok && remoteTask != "" {
 		if !isValidBool(remoteTask) {
 			return fmt.Errorf("invalid value for key %v, acceptable values: true or false", RemoteTasksKey)
 		}
 	}
 
-	if check, ok := config[BitbucketCloudCheckSourceIPKey]; ok {
+	if check, ok := config[BitbucketCloudCheckSourceIPKey]; ok && check != "" {
 		if !isValidBool(check) {
 			return fmt.Errorf("invalid value for key %v, acceptable values: true or false", BitbucketCloudCheckSourceIPKey)
 		}
@@ -39,13 +39,13 @@ func Validate(config map[string]string) error {
 		}
 	}
 
-	if check, ok := config[AutoConfigureNewGitHubRepoKey]; ok {
+	if check, ok := config[AutoConfigureNewGitHubRepoKey]; ok && check != "" {
 		if !isValidBool(check) {
 			return fmt.Errorf("invalid value for key %v, acceptable values: true or false", AutoConfigureNewGitHubRepoKey)
 		}
 	}
 
-	if dashboardURL, ok := config[TektonDashboardURLKey]; ok {
+	if dashboardURL, ok := config[TektonDashboardURLKey]; ok && dashboardURL != "" {
 		if _, err := url.ParseRequestURI(dashboardURL); err != nil {
 			return fmt.Errorf("invalid value for key %v, invalid url: %w", TektonDashboardURLKey, err)
 		}

pkg/params/settings/validation_test.go

@@ -58,6 +58,19 @@ func TestValidate(t *testing.T) {
 			},
 			wantErr: "invalid value for key tekton-dashboard-url, invalid url: parse \"abc.xyz\": invalid URI for request",
 		},
+		{
+			name: "empty values",
+			config: map[string]string{
+				RemoteTasksKey:                 "",
+				SecretAutoCreateKey:            "",
+				BitbucketCloudCheckSourceIPKey: "",
+				TektonDashboardURLKey:          "",
+				MaxKeepRunUpperLimitKey:        "",
+				AutoConfigureNewGitHubRepoKey:  "",
+				DefaultMaxKeepRunsKey:          "",
+			},
+			wantErr: "",
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {