doc: remove plan permissions for GitHub app

Remove plan permissions from the organization permissions as it's not
required.

Signed-off-by: Chmouel Boudjnah <[email protected]>

Author: chmouel

docs/content/docs/install/github_apps.md

@@ -42,7 +42,6 @@ Alternatively, you could set up manually by following the steps [here](./#setup-
 
 * Select the following organization permissions:
   * **Members**: `Readonly`
-  * **Plan**: `Readonly`
 
 * Subscribe to following events:
   * Check run

pkg/cmd/tknpac/bootstrap/github.go

@@ -27,13 +27,12 @@ func generateManifest(opts *bootstrapOpts) ([]byte, error) {
 			"push",
 		},
 		DefaultPermissions: &github.InstallationPermissions{
-			Checks:           github.Ptr("write"),
-			Contents:         github.Ptr("write"),
-			Issues:           github.Ptr("write"),
-			Members:          github.Ptr("read"),
-			Metadata:         github.Ptr("read"),
-			OrganizationPlan: github.Ptr("read"),
-			PullRequests:     github.Ptr("write"),
+			Checks:       github.Ptr("write"),
+			Contents:     github.Ptr("write"),
+			Issues:       github.Ptr("write"),
+			Members:      github.Ptr("read"),
+			Metadata:     github.Ptr("read"),
+			PullRequests: github.Ptr("write"),
 		},
 	}
 	return json.Marshal(sc)

test/github_pullrequest_retest_test.go

@@ -18,6 +18,8 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
 
+// TestGithubSecondPullRequestGitopsCommentRetest will test the retest
+// functionality of a GitHub pull request.
 func TestGithubSecondPullRequestGitopsCommentRetest(t *testing.T) {
 	if os.Getenv("NIGHTLY_E2E_TEST") != "true" {
 		t.Skip("Skipping test since only enabled for nightly")