Added a check to watch on secret pipelines-as-code-secret to decide GithubApp or Webhook

Author: savitaashture

pkg/cli/info/configmap.go

@@ -4,6 +4,7 @@ import (
 	"context"
 
 	"github.com/openshift-pipelines/pipelines-as-code/pkg/params"
+	"github.com/openshift-pipelines/pipelines-as-code/pkg/pipelineascode"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
 
@@ -15,6 +16,13 @@ type Options struct {
 	Provider        string
 }
 
+func IsGithubAppInstalled(ctx context.Context, run *params.Run, targetNamespace string) bool {
+	if _, err := run.Clients.Kube.CoreV1().Secrets(targetNamespace).Get(ctx, pipelineascode.DefaultPipelinesAscodeSecretName, metav1.GetOptions{}); err != nil {
+		return false
+	}
+	return true
+}
+
 func GetPACInfo(ctx context.Context, run *params.Run, targetNamespace string) (*Options, error) {
 	cm, err := run.Clients.Kube.CoreV1().ConfigMaps(targetNamespace).Get(ctx, infoConfigMap, metav1.GetOptions{})
 	if err != nil {

pkg/cmd/tknpac/bootstrap/bootstrap.go

@@ -10,7 +10,6 @@ import (
 	"github.com/openshift-pipelines/pipelines-as-code/pkg/cli/info"
 	"github.com/openshift-pipelines/pipelines-as-code/pkg/params"
 	"github.com/openshift-pipelines/pipelines-as-code/pkg/params/settings"
-	"github.com/openshift-pipelines/pipelines-as-code/pkg/provider"
 	"github.com/spf13/cobra"
 	kapierror "k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -151,13 +150,8 @@ func Command(run *params.Run, ioStreams *cli.IOStreams) *cobra.Command {
 				}
 			}
 
-			pacInfo, err := info.GetPACInfo(ctx, run, opts.targetNamespace)
-			if err != nil {
-				return err
-			}
-
 			if !opts.forceGitHubApp {
-				if pacInfo.Provider == provider.ProviderGitHubApp {
+				if info.IsGithubAppInstalled(ctx, run, opts.targetNamespace) {
 					fmt.Fprintln(opts.ioStreams.Out, "👌 Skips bootstrapping GitHub App, as one is already configured. Please pass --force-configure to override existing")
 					return nil
 				}
@@ -214,13 +208,8 @@ func GithubApp(run *params.Run, ioStreams *cli.IOStreams) *cobra.Command {
 				return err
 			}
 
-			pacInfo, err := info.GetPACInfo(ctx, run, opts.targetNamespace)
-			if err != nil {
-				return err
-			}
-
 			if !opts.forceGitHubApp {
-				if pacInfo.Provider == provider.ProviderGitHubApp {
+				if info.IsGithubAppInstalled(ctx, run, opts.targetNamespace) {
 					fmt.Fprintln(opts.ioStreams.Out, "👌 Skips bootstrapping GitHub App, as one is already configured. Please pass --force-configure to override existing")
 					return nil
 				}

pkg/cmd/tknpac/create/repository.go

@@ -20,7 +20,6 @@ import (
 	"github.com/openshift-pipelines/pipelines-as-code/pkg/git"
 	"github.com/openshift-pipelines/pipelines-as-code/pkg/params"
 	"github.com/openshift-pipelines/pipelines-as-code/pkg/params/info"
-	"github.com/openshift-pipelines/pipelines-as-code/pkg/provider"
 	"github.com/spf13/cobra"
 	v1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -81,12 +80,8 @@ func repositoryCommand(run *params.Run, ioStreams *cli.IOStreams) *cobra.Command
 			if err != nil {
 				return err
 			}
-			pacCMInfo, err := pacInfo.GetPACInfo(ctx, run, installationNS)
-			if err != nil {
-				return err
-			}
 
-			if pacCMInfo.Provider == provider.ProviderGitHubApp {
+			if pacInfo.IsGithubAppInstalled(ctx, run, installationNS) {
 				if strings.Contains(createOpts.Event.URL, "github") {
 					if err := createOpts.generateTemplate(nil); err != nil {
 						return err