Skip to content

Commit d723fee

Browse files
committed
fix: update gha workflows
- Remove pull_request_target trigger from nightly_push_dispatch.yaml - Add input for commit SHA with default to main branch - Remove unnecessary tmate setup from pull_request_trusted.yaml
1 parent f51eb61 commit d723fee

File tree

2 files changed

+5
-14
lines changed

2 files changed

+5
-14
lines changed

.github/workflows/nightly_push_dispatch.yaml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,10 @@ on:
1010
description: "Run the build with tmate debugging enabled (https://github.com/marketplace/actions/debugging-with-tmate)"
1111
required: false
1212
default: false
13-
pull_request_target:
14-
types: [opened, synchronize, reopened]
15-
paths:
16-
- "**.go"
17-
13+
sha:
14+
description: "The commit SHA to checkout"
15+
required: false
16+
default: "main"
1817
jobs:
1918
e2e-tests:
2019
concurrency:
@@ -55,7 +54,7 @@ jobs:
5554
steps:
5655
- uses: actions/checkout@v4
5756
with:
58-
ref: ${{ github.sha }}
57+
ref: ${{ inputs.sha || github.sha }}
5958

6059
- uses: actions/setup-go@v5
6160
with:

.github/workflows/pull_request_trusted.yaml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ on:
55
types: [opened, synchronize, reopened]
66
paths:
77
- "**.go"
8-
98
jobs:
109
e2e-tests:
1110
concurrency:
@@ -91,13 +90,6 @@ jobs:
9190
run: |
9291
nohup gosmee client --saveDir /tmp/gosmee-replay ${{ secrets.PYSMEE_URL }} "http://${CONTROLLER_DOMAIN_URL}" &
9392
94-
- name: Setup tmate session
95-
uses: mxschmitt/action-tmate@v3
96-
if: ${{ github.event_name == 'workflow_dispatch' && inputs.debug_enabled }}
97-
with:
98-
detached: true
99-
limit-access-to-actor: true
100-
10193
- name: Start installing cluster
10294
run: |
10395
export PAC_DIR=${PWD}

0 commit comments

Comments
 (0)