fix(gitlab): paginate through MergeRequest notes to locate update marker

This commits adds paging logic when listing commits in the gitlab
CreateComment function.

Previously, only the first 100 notes on a MR were compared when finding
the note to update. Paging through the list of merge request notes
ensures that if a MR has more than 100 comments we will still update
the appropriate comment.

This commit also creates default gitlab paging options which are used by
all gitlab API calls that paginate through the response.

Author: aThorp96

pkg/provider/gitlab/acl.go

@@ -72,7 +72,7 @@ func (v *Provider) checkOkToTestCommentFromApprovedMember(ctx context.Context, e
 	}
 
 	var nextPage int
-	opt := &gitlab.ListMergeRequestDiscussionsOptions{Page: page}
+	opt := &gitlab.ListMergeRequestDiscussionsOptions{Page: page, PerPage: defaultGitlabListOptions.PerPage}
 	discussions, resp, err := v.Client().Discussions.ListMergeRequestDiscussions(v.targetProjectID, event.PullRequestNumber, opt)
 	if err != nil || len(discussions) == 0 {
 		return false, err

pkg/provider/gitlab/gitlab.go

@@ -68,6 +68,10 @@ type Provider struct {
 	cachedChangedFiles *changedfiles.ChangedFiles
 }
 
+var defaultGitlabListOptions = gitlab.ListOptions{
+	PerPage: 100,
+}
+
 func (v *Provider) Client() *gitlab.Client {
 	providerMetrics.RecordAPIUsage(
 		v.Logger,
@@ -99,24 +103,33 @@ func (v *Provider) CreateComment(_ context.Context, event *info.Event, commit, u
 
 	// List comments of the merge request
 	if updateMarker != "" {
-		comments, _, err := v.Client().Notes.ListMergeRequestNotes(event.TargetProjectID, event.PullRequestNumber, &gitlab.ListMergeRequestNotesOptions{
-			ListOptions: gitlab.ListOptions{
-				Page:    1,
-				PerPage: 100,
-			},
-		})
-		if err != nil {
-			return err
-		}
+		options := []gitlab.RequestOptionFunc{}
 
-		re := regexp.MustCompile(updateMarker)
-		for _, comment := range comments {
-			if re.MatchString(comment.Body) {
-				_, _, err := v.Client().Notes.UpdateMergeRequestNote(event.TargetProjectID, event.PullRequestNumber, comment.ID, &gitlab.UpdateMergeRequestNoteOptions{
-					Body: &commit,
-				})
+		for {
+			comments, resp, err := v.Client().Notes.ListMergeRequestNotes(event.TargetProjectID, event.PullRequestNumber, &gitlab.ListMergeRequestNotesOptions{ListOptions: defaultGitlabListOptions}, options...)
+			if err != nil {
 				return err
 			}
+
+			re := regexp.MustCompile(updateMarker)
+			for _, comment := range comments {
+				if re.MatchString(comment.Body) {
+					_, _, err := v.Client().Notes.UpdateMergeRequestNote(event.TargetProjectID, event.PullRequestNumber, comment.ID, &gitlab.UpdateMergeRequestNoteOptions{
+						Body: &commit,
+					})
+					return err
+				}
+			}
+
+			// Exit the loop when we've seen all pages.
+			if resp.NextLink == "" {
+				break
+			}
+
+			// Otherwise, set param to query the next page
+			options = []gitlab.RequestOptionFunc{
+				gitlab.WithKeysetPaginationParameters(resp.NextLink),
+			}
 		}
 	}
 
@@ -386,7 +399,7 @@ func (v *Provider) GetTektonDir(_ context.Context, event *info.Event, path, prov
 		ListOptions: gitlab.ListOptions{
 			OrderBy:    "id",
 			Pagination: "keyset",
-			PerPage:    20,
+			PerPage:    defaultGitlabListOptions.PerPage,
 			Sort:       "asc",
 		},
 	}
@@ -524,7 +537,7 @@ func (v *Provider) fetchChangedFiles(_ context.Context, runevent *info.Event) (c
 			ListOptions: gitlab.ListOptions{
 				OrderBy:    "id",
 				Pagination: "keyset",
-				PerPage:    20,
+				PerPage:    defaultGitlabListOptions.PerPage,
 				Sort:       "asc",
 			},
 		}
@@ -564,7 +577,7 @@ func (v *Provider) fetchChangedFiles(_ context.Context, runevent *info.Event) (c
 			}
 		}
 	case triggertype.Push:
-		options := gitlab.GetCommitDiffOptions{}
+		options := gitlab.GetCommitDiffOptions{ListOptions: defaultGitlabListOptions}
 		pageOpts := []gitlab.RequestOptionFunc{}
 
 		for {