Revert "sleep between running tests"

This reverts commit f697eeb.

Author: chmouel

test/pkg/gitea/setup.go

@@ -6,7 +6,6 @@ import (
 	"os"
 	"strings"
 	"testing"
-	"time"
 
 	"github.com/google/go-github/v53/github"
 	"gotest.tools/v3/assert"
@@ -82,7 +81,6 @@ func TearDown(ctx context.Context, t *testing.T, topts *TestOpts) {
 		topts.ParamsRun.Clients.Log.Infof("Not cleaning up and closing PR since TEST_NOCLEANUP is set")
 		return
 	}
-	time.Sleep(5 * time.Second)
 	repository.NSTearDown(ctx, t, topts.ParamsRun, topts.TargetNS)
 	_, err := topts.GiteaCNX.Client.DeleteRepo(topts.Opts.Organization, topts.TargetNS)
 	assert.NilError(t, err)

test/pkg/github/pr.go

@@ -9,14 +9,13 @@ import (
 	"testing"
 
 	"github.com/google/go-github/v53/github"
-	"github.com/tektoncd/pipeline/pkg/names"
-	"gotest.tools/v3/assert"
-
 	"github.com/openshift-pipelines/pipelines-as-code/pkg/params"
 	ghprovider "github.com/openshift-pipelines/pipelines-as-code/pkg/provider/github"
 	"github.com/openshift-pipelines/pipelines-as-code/test/pkg/options"
 	"github.com/openshift-pipelines/pipelines-as-code/test/pkg/payload"
 	"github.com/openshift-pipelines/pipelines-as-code/test/pkg/wait"
+	"github.com/tektoncd/pipeline/pkg/names"
+	"gotest.tools/v3/assert"
 )
 
 func PushFilesToRef(ctx context.Context, client *github.Client, commitMessage, baseBranch, targetRef, owner, repo string, files map[string]string) (string, error) {

test/pkg/github/setup.go

@@ -7,7 +7,6 @@ import (
 	"strconv"
 	"strings"
 	"testing"
-	"time"
 
 	ghlib "github.com/google/go-github/v53/github"
 	"gotest.tools/v3/assert"
@@ -106,8 +105,6 @@ func TearDown(ctx context.Context, t *testing.T, runcnx *params.Run, ghprovider
 		runcnx.Clients.Log.Infof("Not cleaning up and closing PR since TEST_NOCLEANUP is set")
 		return
 	}
-	runcnx.Clients.Log.Infof("Sleeping 5 seconds just for giggles and CI flakes")
-	time.Sleep(5 * time.Second)
 	runcnx.Clients.Log.Infof("Closing PR %d", prNumber)
 	if prNumber != -1 {
 		state := "closed"