use github apps installation token to run the test

we use a generated github apps token for github to run the tests which
has a much upper limit than PAT.

Signed-off-by: Chmouel Boudjnah <[email protected]>

Author: chmouel

pkg/provider/github/github.go

@@ -110,7 +110,7 @@ func (v *Provider) GetTaskURI(ctx context.Context, _ *params.Run, event *info.Ev
 
 func (v *Provider) InitAppClient(ctx context.Context, kube kubernetes.Interface, event *info.Event) error {
 	var err error
-	event.Provider.Token, err = v.getAppToken(ctx, kube, event.GHEURL, event.InstallationID)
+	event.Provider.Token, err = v.GetAppToken(ctx, kube, event.GHEURL, event.InstallationID)
 	if err != nil {
 		return err
 	}

pkg/provider/github/parse_payload.go

@@ -25,7 +25,7 @@ const (
 	secretName = "pipelines-as-code-secret"
 )
 
-func (v *Provider) getAppToken(ctx context.Context, kube kubernetes.Interface, gheURL string, installationID int64) (string, error) {
+func (v *Provider) GetAppToken(ctx context.Context, kube kubernetes.Interface, gheURL string, installationID int64) (string, error) {
 	// TODO: move this out of here
 	ns := os.Getenv("SYSTEM_NAMESPACE")
 	secret, err := kube.CoreV1().Secrets(ns).Get(ctx, secretName, v1.GetOptions{})
@@ -137,7 +137,7 @@ func (v *Provider) ParsePayload(ctx context.Context, run *params.Run, request *h
 	installationIDFrompayload := getInstallationIDFromPayload(payload)
 	if installationIDFrompayload != -1 {
 		var err error
-		if event.Provider.Token, err = v.getAppToken(ctx, run.Clients.Kube, event.Provider.URL, installationIDFrompayload); err != nil {
+		if event.Provider.Token, err = v.GetAppToken(ctx, run.Clients.Kube, event.Provider.URL, installationIDFrompayload); err != nil {
 			return nil, err
 		}
 	}
@@ -176,7 +176,7 @@ func (v *Provider) ParsePayload(ctx context.Context, run *params.Run, request *h
 			}
 		}
 		var err error
-		if processedEvent.Provider.Token, err = v.getAppToken(ctx, run.Clients.Kube, event.Provider.URL,
+		if processedEvent.Provider.Token, err = v.GetAppToken(ctx, run.Clients.Kube, event.Provider.URL,
 			installationIDFrompayload); err != nil {
 			return nil, err
 		}

test/pkg/github/setup.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"fmt"
 	"os"
+	"strconv"
 	"strings"
 	"testing"
 
@@ -17,8 +18,8 @@ import (
 )
 
 func Setup(ctx context.Context, viaDirectWebhook bool) (*params.Run, options.E2E, *github.Provider, error) {
+	githubToken := ""
 	githubURL := os.Getenv("TEST_GITHUB_API_URL")
-	githubToken := os.Getenv("TEST_GITHUB_TOKEN")
 	githubRepoOwnerGithubApp := os.Getenv("TEST_GITHUB_REPO_OWNER_GITHUBAPP")
 	githubRepoOwnerDirectWebhook := os.Getenv("TEST_GITHUB_REPO_OWNER_WEBHOOK")
 
@@ -36,12 +37,13 @@ func Setup(ctx context.Context, viaDirectWebhook bool) (*params.Run, options.E2E
 
 	var splitted []string
 	if !viaDirectWebhook {
-		if githubURL == "" || githubToken == "" || githubRepoOwnerGithubApp == "" {
-			return nil, options.E2E{}, github.New(), fmt.Errorf("TEST_GITHUB_API_URL TEST_GITHUB_TOKEN TEST_GITHUB_REPO_OWNER_GITHUBAPP need to be set")
+		if githubURL == "" || githubRepoOwnerGithubApp == "" {
+			return nil, options.E2E{}, github.New(), fmt.Errorf("TEST_GITHUB_API_URL TEST_GITHUB_REPO_OWNER_GITHUBAPP need to be set")
 		}
 		splitted = strings.Split(githubRepoOwnerGithubApp, "/")
 	}
 	if viaDirectWebhook {
+		githubToken = os.Getenv("TEST_GITHUB_TOKEN")
 		if githubURL == "" || githubToken == "" || githubRepoOwnerDirectWebhook == "" {
 			return nil, options.E2E{}, github.New(), fmt.Errorf("TEST_GITHUB_API_URL TEST_GITHUB_TOKEN TEST_GITHUB_REPO_OWNER_WEBHOOK need to be set")
 		}
@@ -52,9 +54,35 @@ func Setup(ctx context.Context, viaDirectWebhook bool) (*params.Run, options.E2E
 	if err := run.Clients.NewClients(ctx, &run.Info); err != nil {
 		return nil, options.E2E{}, github.New(), err
 	}
+
 	e2eoptions := options.E2E{Organization: splitted[0], Repo: splitted[1], DirectWebhook: viaDirectWebhook}
 	gprovider := github.New()
 	event := info.NewEvent()
+
+	if githubToken == "" && !viaDirectWebhook {
+		var err error
+		// check if SYSTEM_NAMESPACE is set otherwise set it
+		if os.Getenv("SYSTEM_NAMESPACE") == "" {
+			if err := os.Setenv("SYSTEM_NAMESPACE", "pipelines-as-code"); err != nil {
+				return &params.Run{}, options.E2E{}, &github.Provider{}, err
+			}
+		}
+
+		envGithubRepoInstallationID := os.Getenv("TEST_GITHUB_REPO_INSTALLATION_ID")
+		if envGithubRepoInstallationID == "" {
+			return nil, options.E2E{}, github.New(), fmt.Errorf("TEST_GITHUB_REPO_INSTALLATION_ID need to be set")
+		}
+		// convert to int64 githubRepoInstallationID
+		githubRepoInstallationID, err := strconv.ParseInt(envGithubRepoInstallationID, 10, 64)
+		if err != nil {
+			return nil, options.E2E{}, github.New(), fmt.Errorf("TEST_GITHUB_REPO_INSTALLATION_ID need to be set")
+		}
+		githubToken, err = gprovider.GetAppToken(ctx, run.Clients.Kube, githubURL, githubRepoInstallationID)
+		if err != nil {
+			return nil, options.E2E{}, github.New(), err
+		}
+	}
+
 	event.Provider = &info.Provider{
 		Token: githubToken,
 		URL:   githubURL,