fix: Do not return error when PipelineRun patching is failed #2338
Conversation
Summary of ChangesHello @zakisk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where a failure to patch a Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the error handling for PipelineRun patching. When patching a PipelineRun fails, it will now log the error instead of returning it, preventing a failed status check on the git provider for a non-critical issue. The core logic change is sound. However, the accompanying test modifications appear to have broken the test case for patch failures. I've provided a detailed comment and a code suggestion to rectify the test.
|
/test |
🔍 PR Lint Feedback
|
when PipelineRun patch is failed in startPR func, PaC was returning error which was creating a failed check on git provider though PipelineRun was running and it was making user confused, this commit fixes that. https://issues.redhat.com/browse/SRVKP-9345 Signed-off-by: Zaki Shaikh <[email protected]>
zakisk
force-pushed
the
SRVKP-9345-prevent-failed-check-after-pr-creation
branch
from
1a6af04 to
c3c8e53
Compare
2 participants
when PipelineRun patch is failed in startPR func, PaC was returning error which was creating a failed check on git provider though PipelineRun was running and it was making user confused, this commit fixes that.
https://issues.redhat.com/browse/SRVKP-9345
📝 Description of the Change
👨🏻 Linked Jira
🔗 Linked GitHub Issue
Fixes #
🚀 Type of Change
fix:)feat:)feat!:,fix!:)docs:)chore:)refactor:)enhance:)deps:)🧪 Testing Strategy
🤖 AI Assistance
If you have used AI assistance, please provide the following details:
Which LLM was used?
Extent of AI Assistance:
Important
If the majority of the code in this PR was generated by an AI, please add a
Co-authored-bytrailer to your commit message.For example:
Co-authored-by: Gemini [email protected]
Co-authored-by: ChatGPT [email protected]
Co-authored-by: Claude [email protected]
Co-authored-by: Cursor [email protected]
Co-authored-by: Copilot [email protected]
**💡You can use the script
./hack/add-llm-coauthor.shto automatically addthese co-author trailers to your commits.
✅ Submitter Checklist
fix:,feat:) matches the "Type of Change" I selected above.make testandmake lintlocally to check for and fix anyissues. For an efficient workflow, I have considered installing
pre-commit and running
pre-commit installtoautomate these checks.