-
Notifications
You must be signed in to change notification settings - Fork 117
feat(cel): require body and headers flags #2339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(cel): require body and headers flags #2339
Conversation
Make --body and --headers flags required since both are essential for the cel command to function. Refactor tests accordingly. Jira: https://issues.redhat.com/browse/SRVKP-9400 Signed-off-by: Akshay Pant <[email protected]>
Summary of ChangesHello @theakshaypant, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with π and π on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
π PR Lint Feedback
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly makes the --body and --headers flags required for the cel command, which is a logical improvement since they are essential for the command's operation. The implementation using cmd.MarkFlagRequired is appropriate, and the associated documentation and test updates are thorough and well-executed. The refactoring of the test suite, including the addition of the setupCELTest helper function, significantly improves the clarity and maintainability of the tests. Overall, this is a high-quality contribution with no issues found.
π Description of the Change
Make --body and --headers flags required since both are essential for the cel command to function. Refactor tests accordingly.
π¨π»β Linked Jira
https://issues.redhat.com/browse/SRVKP-9400
π Linked GitHub Issue
N/A
π Type of Change
fix:)feat:)feat!:,fix!:)docs:)chore:)refactor:)enhance:)deps:)π§ͺ Testing Strategy
π€ AI Assistance
If you have used AI assistance, please provide the following details:
Which LLM was used?
Extent of AI Assistance:
Important
If the majority of the code in this PR was generated by an AI, please add a
Co-authored-bytrailer to your commit message.For example:
Co-authored-by: Gemini [email protected]
Co-authored-by: ChatGPT [email protected]
Co-authored-by: Claude [email protected]
Co-authored-by: Cursor [email protected]
Co-authored-by: Copilot [email protected]
**π‘You can use the script
./hack/add-llm-coauthor.shto automatically addthese co-author trailers to your commits.
β Submitter Checklist
fix:,feat:) matches the "Type of Change" I selected above.make testandmake lintlocally to check for and fix anyissues. For an efficient workflow, I have considered installing
pre-commit and running
pre-commit installtoautomate these checks.