Skip to content

fix: correctly update pending and running commit status #2341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: correctly update pending and running commit status #2341

wants to merge 1 commit into from
+31 −0

Conversation

@ab-ghosh
Copy link
Member

@ab-ghosh ab-ghosh commented Nov 28, 2025

📝 Description of the Change

Fix GitLab commit status handling for two issues:

  1. Incorrect status mapping: When waiting for /ok-to-test approval, GitLab was showing "Pipeline running" instead of "Pipeline pending". The pending conclusion was incorrectly mapped to GitLab's running state.

  2. Parent status not updated: The initial "Pipelines as Code CI" status (without pipeline name) created when waiting for /ok-to-test was never updated when the actual pipeline started or completed. Only the pipeline-specific status ("Pipelines as Code CI / <name>") was being updated.

  • pkg/provider/gitlab/gitlab.go: Fix status mapping - pending → pending, in_progress → running
  • pkg/pipelineascode/pipelineascode.go: Update parent status when pipeline starts
  • pkg/reconciler/reconciler.go: Update parent status when pipeline transitions to running
  • pkg/reconciler/status.go: Update parent status when pipeline completes

👨🏻‍ Linked Jira

Jira: https://issues.redhat.com/browse/SRVKP-9459

🔗 Linked GitHub Issue

Fixes #

🚀 Type of Change

  • 🐛 Bug fix (fix:)
  • ✨ New feature (feat:)
  • 💥 Breaking change (feat!:, fix!:)
  • 📚 Documentation update (docs:)
  • ⚙️ Chore (chore:)
  • 💅 Refactor (refactor:)
  • 🔧 Enhancement (enhance:)
  • 📦 Dependency update (deps:)

🧪 Testing Strategy

  • Unit tests
  • Integration tests
  • End-to-end tests
  • Manual testing
  • Not Applicable

🤖 AI Assistance

  • I have not used any AI assistance for this PR.
  • I have used AI assistance for this PR.

If you have used AI assistance, please provide the following details:

Which LLM was used?

  • GitHub Copilot
  • ChatGPT (OpenAI)
  • Claude (Anthropic)
  • Cursor
  • Gemini (Google)
  • Other: ____________

Extent of AI Assistance:

  • Documentation and research only
  • Unit tests or E2E tests only
  • Code generation (parts of the code)
  • Full code generation (most of the PR)
  • PR description and comments
  • Commit message(s)

Important

If the majority of the code in this PR was generated by an AI, please add a Co-authored-by trailer to your commit message.
For example:

Co-authored-by: Gemini [email protected]
Co-authored-by: ChatGPT [email protected]
Co-authored-by: Claude [email protected]
Co-authored-by: Cursor [email protected]
Co-authored-by: Copilot [email protected]

**💡You can use the script ./hack/add-llm-coauthor.sh to automatically add
these co-author trailers to your commits.

✅ Submitter Checklist

  • 📝 My commit messages are clear, informative, and follow the project's How to write a git commit message guide. The Gitlint linter ensures in CI it's properly validated
  • ✨ I have ensured my commit message prefix (e.g., fix:, feat:) matches the "Type of Change" I selected above.
  • ♽ I have run make test and make lint locally to check for and fix any
    issues. For an efficient workflow, I have considered installing
    pre-commit and running pre-commit install to
    automate these checks.
  • 📖 I have added or updated documentation for any user-facing changes.
  • 🧪 I have added sufficient unit tests for my code changes.
  • 🎁 I have added end-to-end tests where feasible. See README for more details.
  • 🔎 I have addressed any CI test flakiness or provided a clear reason to bypass it.
  • If adding a provider feature, I have filled in the following and updated the provider documentation:
    • GitHub App
    • GitHub Webhook
    • Gitea/Forgejo
    • GitLab
    • Bitbucket Cloud
    • Bitbucket Data Center

@gemini-code-assist
Copy link

gemini-code-assist bot commented Nov 28, 2025

Summary of Changes

Hello @ab-ghosh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses two critical issues related to GitLab commit status reporting within the system. The primary goal is to ensure that commit statuses accurately reflect the state of pipelines, preventing confusion for users. It corrects an incorrect mapping of 'pending' states and ensures that the overarching 'Pipelines as Code CI' status is consistently updated from start to finish, providing a more reliable and transparent view of pipeline execution.

Highlights

  • GitLab Status Mapping Correction: The mapping for GitLab commit statuses has been corrected. Previously, a 'pending' conclusion was incorrectly displayed as 'Pipeline running'. Now, 'pending' states (like waiting for /ok-to-test) will correctly show as 'pending', and 'in_progress' states will show as 'running'.
  • Parent Status Updates: The initial 'Pipelines as Code CI' status, which is set without a specific pipeline name when waiting for /ok-to-test approval, will now be correctly updated throughout the pipeline's lifecycle. This includes updates when the pipeline starts, transitions to an in-progress state, and when it finally completes, ensuring a consistent and accurate overall status.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@pipelines-as-code
Copy link

pipelines-as-code bot commented Nov 28, 2025

🔍 PR Lint Feedback

Note: This automated check helps ensure your PR follows our contribution guidelines.

⚠️ Items that need attention:

🤖 AI attribution

The following commits lack an explicit AI attribution footer:

  • 8f10b7c fix: correctly update pending and running commit status

If no AI assistance was used for a commit, you can ignore this warning.
Otherwise add an Assisted-by: or Co-authored-by: footer referencing the AI used.

ℹ️ Next Steps

  • Review and address the items above
  • Push new commits to update this PR
  • This comment will be automatically updated when issues are resolved
🔧 Admin Tools (click to expand)

Automated Issue/Ticket Creation:

  • /issue-create - Generate a GitHub issue from this PR content using AI
  • /jira-create - Create a SRVKP Jira ticket from this PR content using AI

⚠️ Important: Always review and edit generated content before finalizing tickets/issues.
The AI-generated content should be used as a starting point and may need adjustments.

These commands are available to maintainers and will post the generated content as PR comments for review.

🤖 This feedback was generated automatically by the PR CI system

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 28, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes two issues with GitLab commit status updates: the mapping of the pending status and the missing updates for the parent commit status. The changes look good and address the described problems. I've added a few suggestions to improve the implementation by reducing code duplication and making the status updates more robust by using the existing retry mechanism consistently.

@ab-ghosh ab-ghosh force-pushed the fix-gitlab-pending-status-mapping branch from 8f10b7c to 6843d69 Compare November 28, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix gitlab

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ab-ghosh