[matrix_benchmarking] library: visualize: don't skip the upload if a regression has been detected (#859)

…

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Bug Fixes**
* Uploads now proceed when the only blocker is a regression flag, while
still blocking for other non-fatal errors—improves upload reliability.

* **Chores**
  * Added an automated Python syntax check workflow for pull requests.
* Updated CI workflow metadata and checkout action versions across
several workflows.
* Minor string-escaping fixes in a few scripts to prevent invalid
escapes.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Author: kpouget

.github/workflows/ansible-lint.yml

@@ -13,13 +13,13 @@ on:
 # A workflow run is made up of one or more jobs that can run sequentially or in parallel
 jobs:
   # This workflow contains a single job called "build"
-  build:
+  check_ansible_lint:
     # The type of runner that the job will run on
     runs-on: ubuntu-latest
 
     steps:
     # Important: This sets up your GITHUB_WORKSPACE environment variable
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
 
     - name: Set ANSIBLE_ROLES_PATH
       run: |

.github/workflows/build_docs.yml

@@ -8,15 +8,15 @@ on:
     - cron: '0 */8 * * *'
 
 jobs:
-  build:
+  build_docs:
     runs-on: ubuntu-latest
     strategy:
       max-parallel: 4
       matrix:
         python-version: [3.9]
     steps:
       - name: Use checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
 

.github/workflows/check_consistency.yml

@@ -11,11 +11,11 @@ on:
     - cron: '0 */8 * * *'
 
 jobs:
-  build:
+  check_topsail_consistency:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
 

.github/workflows/check_generated_ansible.yml

@@ -11,11 +11,11 @@ on:
     - cron: '0 */8 * * *'
 
 jobs:
-  build:
+  check_generated_ansible:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
 

.github/workflows/check_generated_toolbox_rst.yml

@@ -11,11 +11,11 @@ on:
     - cron: '0 */8 * * *'
 
 jobs:
-  build:
+  check_generated_rst:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
 

.github/workflows/check_python_syntax.yml

@@ -0,0 +1,24 @@
+name: Check the Python syntax
+
+on:
+  pull_request:
+    branches: [main]
+jobs:
+  check_python_syntax:
+    runs-on: ubuntu-latest
+    strategy:
+      max-parallel: 4
+      matrix:
+        python-version: [3.9]
+    steps:
+      - name: Use checkout
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+
+      - name: Check that all the files can be compiled
+        run: |
+          set -o pipefail
+          set -o errexit
+
+          python -m compileall . | (grep -v -E '(^Listing|^Compiling)' || true)

.github/workflows/check_wip.yml

@@ -5,11 +5,11 @@ on:
     branches: [main]
 
 jobs:
-  build:
+  check_wip:
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
       with:
         fetch-depth: 0
 

projects/core/library/config.py

@@ -390,13 +390,13 @@ def test_skip_list():
     if exec_this_subcommand is False:
         logging.fatal(f"Subcommand '{current_subcommand}' is disabled in the exec list. Stopping happily this execution.")
         with open(env.ARTIFACT_DIR / "SKIPPED", "w") as f:
-            print("Skipped because part of the \skip list", file=f)
+            print("Skipped because part of the \\skip list", file=f)
         raise SystemExit(0)
 
     if exec_this_subcommand is not True and exec_list.get("_only_", False):
         logging.fatal(f"Only flag is set, and subcommand '{current_subcommand}' is not enabled in the exec list. Stopping happily this execution.")
         with open(env.ARTIFACT_DIR / "SKIPPED", "w") as f:
-            print("Skipped because not part of the \only list", file=f)
+            print("Skipped because not part of the \\only list", file=f)
 
         raise SystemExit(0)
 

projects/deprecated/notebooks/toolbox/notebooks_locust_scale_test/files/locust-files/entrypoint.py

@@ -28,7 +28,7 @@
     -outfile $ARTIFACT_DIR/{LOCUST_FILE_PREFIX}_report.html \
 "
 
-REMOVE_NA_CMD = "sed -i '/N\/A/d' {file}"
+REMOVE_NA_CMD = r"sed -i '/N\/A/d' {file}"
 
 artifacts_directory = pathlib.Path(os.getenv("ARTIFACT_DIR"))
 

projects/deprecated/notebooks/toolbox/notebooks_locust_scale_test/files/locust-files/jupyterlab.py

@@ -111,7 +111,7 @@ def get_jupyterlab_page(self, base_url):
 
         soup = BeautifulSoup(response.text, features="lxml")
         if soup.title and soup.title.text == "JupyterLab":
-            logging.info(f"Reached JupyterLab page \o/")
+            logging.info(f"Reached JupyterLab page \\o/")
 
         elif soup.title and "Log in" in soup.title.text:
             raise common.ScaleTestError(f"JupyterLab home page failed to load properly... (still on the login page)",