Skip to content

Commit 11c9c1a

Browse files
committed
Changed variable name for access modes
ACCESS_MODES -> PVCSCALE_ACCESS_MODES Added new variable PVCSCALE_NODESELECTOR to cover case when pods are required to start on nodes with particular label.
1 parent 54308f3 commit 11c9c1a

File tree

3 files changed

+12
-5
lines changed

3 files changed

+12
-5
lines changed

docs/pvcscale.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,10 +115,15 @@ This is default PVC size. If specified as `1Gi` then all Pods will get `1Gi` PVC
115115
Default: None
116116
The storageclass which will be used to allocated PVCs. It has to be present on cluster and must be functional for test to work. Default is unset and must be changed prior running test and adapted to name of functional storage class name.
117117

118-
### ACCESS_MODES
118+
### PVCSCALE_ACCESS_MODES
119119
Default: `ReadWriteOnce`
120-
`ACCESS_MODES` is access_mode for PVC inside Pod. This field does not affect the test itself and might be removed in the future.
120+
`PVCSCALE_ACCESS_MODES` is access_mode for PVC inside Pod. This field does not affect the test itself and might be removed in the future.
121121

122+
### PVCSCALE_NODESELECTOR
123+
124+
Default: None
125+
If there is need for Pods to start on specific nodes based on node selector this parameter will ensure that Pods
126+
are starting on nodes with desired labels. It is prerequst that nodes are labeled with proper labels.
122127
### Smoke test variables
123128

124129
```

workloads/templates/workload-pvcscale-script-cm.yml.j2

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,6 +283,7 @@ data:
283283
basename: {{ pvcscale_basename }}
284284
tuning: default
285285
ifexists: delete
286+
nodeselector: {{ pvcscale_nodeselector }}
286287
templates:
287288
- num: {{ pvcscale_maxpods }}
288289
basename: pvcscale
@@ -314,7 +315,7 @@ data:
314315
volume.beta.kubernetes.io/storage-class: {{ pvcscale_storageclass }}
315316
spec:
316317
accessModes:
317-
- {{ access_modes }}
318+
- {{ pvcscale_access_modes }}
318319
resources:
319320
requests:
320321
storage: {{ pvcscale_storage_size }}

workloads/vars/pvcscale.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ pvcscale_maxpods: "{{ lookup('env', 'PVCSCALE_MAXPODS')|default(10, true)|int }}
4141
pvcscale_pod_image: "{{ lookup('env', 'PVCSCALE_POD_IMAGE')|default('quay.io/openshift-scale/scale-ci-workload', true) }}"
4242
pvcscale_stepsize: "{{ lookup('env', 'PVCSCALE_STEPSIZE')|default(1, true)|int }}"
4343
pvcscale_pause: "{{ lookup('env', 'PVCSCALE_PAUSE')|default(0, true)|int }}"
44-
pvcscale_storage_size: "{{ lookup('env', 'PVCSCALE_STORAGE_SIZE')|default('1Gi',true) }}"
44+
pvcscale_storage_size: "{{ lookup('env', 'PVCSCALE_STORAGE_SIZE')|default('1Gi', true) }}"
4545
pvcscale_storageclass: "{{ lookup('env', 'PVCSCALE_STORAGECLASS')|default('', true) }}"
46-
access_modes: "{{ lookup('env', 'ACCESS_MODES')|default('ReadWriteOnce',true) }}"
46+
pvcscale_access_modes: "{{ lookup('env', 'PVCSCALE_ACCESS_MODES')|default('ReadWriteOnce',true) }}"
47+
pvcscale_nodeselector: "{{ lookup('env', 'PVCSCALE_NODESELECTOR')|default('', true) }}"

0 commit comments

Comments
 (0)