Skip to content

Commit 9f23952

Browse files
akrzoschaitanyaenr
authored andcommitted
Small Docs update
1 parent cd5541c commit 9f23952

File tree

3 files changed

+16
-15
lines changed

3 files changed

+16
-15
lines changed

docs/README.md

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
| Workload/tooling | Short Description | Minimum Requirements |
44
|:-------------------------------------------------- |:----------------------------------------- | ------------------------------------- |
5-
| [Tooling](tooling.md) | Setup pbench metric tools | Cluster-admin, Privileged Containers |
5+
| [Tooling](tooling.md) | Setup pbench instrumentation tools | Cluster-admin, Privileged Containers |
66
| [Test](test.md) | Test/Run your workload from ssh Container | Cluster-admin, Privileged Containers |
77
| [Baseline](baseline.md) | Baseline metrics capture | Tooling job* |
88
| [Scale](scale.md) | Scales worker nodes | Cluster-admin |
@@ -14,15 +14,16 @@
1414
| [Deployments Per Namespace](deployments-per-ns.md) | Maximum Deployments | None |
1515
| [PVCscale](pvscale.md) | PVCScale test | Working storageclass |
1616
| [Conformance](conformance.md) | OCP/Kubernetes e2e tests | None |
17+
1718
* Baseline job without a tooled cluster just idles a cluster. The goal is to capture resource consumption over a period of time to characterize resource requirements thus tooling is required. (For now)
1819

1920
## Network
2021

21-
| Test | Requirement |
22-
|:-------------------------- |:------------------------------------------- |
23-
| Pod 2 Pod | Labeling Nodes |
24-
| Pod 2 Pod with HostNetwork | Labeling Nodes, Open firewall ports at Host |
25-
| Service 2 Service | Labeling Nodes |
22+
| Test | Requirement |
23+
|:--------------------------- |:------------------------------------------- |
24+
| Pod to Pod | Labeling Nodes |
25+
| Pod to Pod with HostNetwork | Labeling Nodes, Open firewall ports at Host |
26+
| Pod to Service | Labeling Nodes |
2627

2728
## CI Pass/Fail
2829

@@ -35,8 +36,8 @@ Each workload will implement a form of pass/fail criteria in order to flag if th
3536
| [Baseline](baseline.md) | NA |
3637
| [Scale](scale.md) | Yes: Test Duration |
3738
| [NodeVertical](nodevertical.md) | Yes: Exit Code, Test Duration |
38-
| [PodVertical](podvertical.md) | In Progress |
39-
| [MasterVertical](mastervertical.md) | In Progress |
39+
| [PodVertical](podvertical.md) | Yes: Exit Code, Test Duration |
40+
| [MasterVertical](mastervertical.md) | Yes: Exit Code, Test Duration |
4041
| [HTTP](http.md) | No |
4142
| [Network](network.md) | No |
4243
| [Deployments Per Namespace](deployments-per-ns.md) | No |

docs/network.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ Pod image to use for pods that are pbench-uperf pods.
8181

8282
### NETWORK_TEST_UPERF_SSHD_PORT
8383
Default: `20000`
84-
Port for pbench to communicate via ssh to server/client pods. Typically this port is not blocked by any firewalls when conducting Pod to Pod and Service to Service uperf benchmarks. Pod to Pod with HostNetwork will require that this port be opened in the cloud environment firewall along with the uperf port range.
84+
Port for pbench to communicate via ssh to server/client pods. Typically this port is not blocked by any firewalls when conducting Pod to Pod and Pod to Service uperf benchmarks. Pod to Pod with HostNetwork will require that this port be opened in the cloud environment firewall along with the uperf port range.
8585

8686
### NETWORK_TEST_UPERF_PORT_RANGE
8787
Default: `20010 20109`
@@ -137,7 +137,7 @@ Enables/disables if the network test will cleanup the project(s) that are create
137137

138138
## Notes for typical Network testing execution
139139

140-
The recommended way to run the Network test is actually three iterations of the network playbook with the following parameters for each run. The first run would test Pod to Pod, the 2nd - Pod to Pod with HostNetwork, and the 3rd - Service to Service which is the most expected usage inside an OpenShift Cluster (Pod -> Svc IP -> Pod).
140+
The recommended way to run the Network test is actually three iterations of the network playbook with the following parameters for each run. The first run would test Pod to Pod, the 2nd - Pod to Pod with HostNetwork, and the 3rd - Pod to Service which is the most expected usage inside an OpenShift Cluster (Pod -> Svc IP -> Pod).
141141

142142
### Suggested Pod to Pod Test Configuration
143143

@@ -181,7 +181,7 @@ NETWORK_TEST_CLEANUP=true
181181

182182
Make sure `NETWORK_TEST_UPERF_SSHD_PORT` is enabled in your cloud environment to permit traffic when using HostNetwork. HostNetwork *requires* "AUDIT_WRITE" capability per scc.
183183

184-
### Suggested Service to Service Test Configuration
184+
### Suggested Pod to Service Test Configuration
185185

186186
```
187187
NETWORK_TEST_UPERF_IMAGE="quay.io/openshift-scale/scale-ci-uperf"
@@ -245,7 +245,7 @@ NETWORK_TEST_SAMPLES=1
245245
NETWORK_TEST_CLEANUP=true
246246
```
247247

248-
### Service to Service smoke test
248+
### Pod to Service smoke test
249249

250250
```
251251
NETWORK_TEST_UPERF_IMAGE="quay.io/openshift-scale/scale-ci-uperf"

workloads/files/workload-network-script-cm.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@ data:
5353
do
5454
log "Running Network benchmarks with ${pair_count} pair(s)"
5555
if [ "${NETWORK_TEST_SERVICE}" == "true" ]; then
56-
config_prefix="S2S"
57-
PAIR_COUNT=${pair_count} envsubst < /root/workload/s2s-network.yaml.template > /tmp/network.yaml
56+
config_prefix="P2S"
57+
PAIR_COUNT=${pair_count} envsubst < /root/workload/p2s-network.yaml.template > /tmp/network.yaml
5858
cp /root/workload/svc-template.yaml /tmp/svc-template.yaml
5959
# Append required ports to service template
6060
for i in `seq ${NETWORK_TEST_UPERF_PORT_RANGE}`
@@ -180,7 +180,7 @@ data:
180180
- NS_VALUE: "client"
181181
- UPERF_IMAGE: ${NETWORK_TEST_UPERF_IMAGE}
182182
- UPERF_SSHD_PORT: ${NETWORK_TEST_UPERF_SSHD_PORT}
183-
s2s-network.yaml.template: |
183+
p2s-network.yaml.template: |
184184
provider: local
185185
ClusterLoader:
186186
cleanup: false

0 commit comments

Comments
 (0)