move stat prefix to constants (#57879)

* move stat prefix to constants

Signed-off-by: Rama Chavali <[email protected]>

* use constants in tests

Signed-off-by: Rama Chavali <[email protected]>

---------

Signed-off-by: Rama Chavali <[email protected]>

Author: ramaraochavali

pkg/istio-agent/xds_proxy_delta_test.go

@@ -35,6 +35,7 @@ import (
 	"istio.io/istio/pkg/config/constants"
 	"istio.io/istio/pkg/test/env"
 	"istio.io/istio/pkg/test/util/assert"
+	wasmcache "istio.io/istio/pkg/wasm"
 )
 
 // Validates basic xds proxy flow by proxying one CDS requests end to end.
@@ -199,7 +200,7 @@ func TestDeltaECDSWasmConversion(t *testing.T) {
 	}
 	httpDenyAll := &httprbac.RBAC{
 		Rules:           &rbacv3.RBAC{},
-		RulesStatPrefix: "wasm-default-deny",
+		RulesStatPrefix: wasmcache.DefaultDenyStatPrefix,
 	}
 	wantEcdsConfig = &core.TypedExtensionConfig{
 		Name:        "extension-config",

pkg/istio-agent/xds_proxy_test.go

@@ -539,7 +539,7 @@ func TestECDSWasmConversion(t *testing.T) {
 	}
 	httpDenyAll := &httprbac.RBAC{
 		Rules:           &rbacv3.RBAC{},
-		RulesStatPrefix: "wasm-default-deny",
+		RulesStatPrefix: wasmcache.DefaultDenyStatPrefix,
 	}
 	wantEcdsConfig = &core.TypedExtensionConfig{
 		Name:        "extension-config",

pkg/wasm/convert.go

@@ -37,26 +37,33 @@ import (
 	"istio.io/istio/pkg/util/protomarshal"
 )
 
+const (
+	// DefaultAllowStatPrefix is the stat prefix used for WASM default allow RBAC filters
+	DefaultAllowStatPrefix = "wasm-default-allow"
+	// DefaultDenyStatPrefix is the stat prefix used for WASM default deny RBAC filters
+	DefaultDenyStatPrefix = "wasm-default-deny"
+)
+
 var (
 	allowHTTPTypedConfig, _ = anypb.New(&httprbac.RBAC{
 		// no rules mean allow all.
-		RulesStatPrefix: "wasm-default-allow",
+		RulesStatPrefix: DefaultAllowStatPrefix,
 	})
 
 	denyHTTPTypedConfig, _ = anypb.New(&httprbac.RBAC{
 		// empty rule means deny all.
 		Rules:           &rbacv3.RBAC{},
-		RulesStatPrefix: "wasm-default-deny",
+		RulesStatPrefix: DefaultDenyStatPrefix,
 	})
 
 	allowNetworkTypeConfig, _ = anypb.New(&networkrbac.RBAC{
 		// no rules mean allow all.
-		StatPrefix: "wasm-default-allow",
+		StatPrefix: DefaultAllowStatPrefix,
 	})
 	denyNetworkTypedConfig, _ = anypb.New(&networkrbac.RBAC{
 		// empty rule means deny all.
 		Rules:      &rbacv3.RBAC{},
-		StatPrefix: "wasm-default-deny",
+		StatPrefix: DefaultDenyStatPrefix,
 	})
 )
 

pkg/wasm/convert_test.go

@@ -480,11 +480,11 @@ var extensionConfigMap = map[string]*core.TypedExtensionConfig{
 		},
 	}),
 	"remote-load-allow": buildAnyExtensionConfig("remote-load-fail", &rbac.RBAC{
-		RulesStatPrefix: "wasm-default-allow",
+		RulesStatPrefix: DefaultAllowStatPrefix,
 	}),
 	"remote-load-deny": buildAnyExtensionConfig("remote-load-fail", &rbac.RBAC{
 		Rules:           &rbacv3.RBAC{},
-		RulesStatPrefix: "wasm-default-deny",
+		RulesStatPrefix: DefaultDenyStatPrefix,
 	}),
 	"remote-load-secret": buildTypedStructExtensionConfig("remote-load-success", &wasm.Wasm{
 		Config: &v3.PluginConfig{