Skip to content

Commit 3f99a50

Browse files
authored
chore: fix wrong function name in comment (#58119)
Signed-off-by: promalert <[email protected]>
1 parent cf6def6 commit 3f99a50

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

tests/integration/helm/util.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ spec:
163163
// ManifestsChartPath is path of local Helm charts used for testing.
164164
var ManifestsChartPath = filepath.Join(env.IstioSrc, "manifests/charts")
165165

166-
// getValuesOverrides returns the values file created to pass into Helm override default values
166+
// GetValuesOverrides returns the values file created to pass into Helm override default values
167167
// for the hub and tag.
168168
//
169169
// Tag can be the empty string, which means the values file will not have a

tools/bug-report/pkg/cluster/cluster.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ func ParsePath(path string) (namespace string, deployment, pod string, container
4343
return pv[0], pv[1], pv[2], pv[3], nil
4444
}
4545

46-
// shouldSkip means that current pod should be skip or not based on given --include and --exclude
46+
// shouldSkipPod means that current pod should be skip or not based on given --include and --exclude
4747
func shouldSkipPod(pod *corev1.Pod, config *config2.BugReportConfig) bool {
4848
for _, eld := range config.Exclude {
4949
if len(eld.Namespaces) > 0 {

tools/istio-iptables/pkg/builder/helper.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ func UndoRules(rules []Rule) []Rule {
107107
return output
108108
}
109109

110-
// BuildCustomCleanup generates a set of iptables commands to clean up unexpected leftover rules and chains.
110+
// BuildCleanupFromState generates a set of iptables commands to clean up unexpected leftover rules and chains.
111111
// The function takes the current state of iptables, represented by a map of table names to their associated chains and rules.
112112
// It first transforms the provided rules into corresponding undo rules.
113113
// It then appends flush and delete commands for each ISTIO_* chain.

tools/istio-iptables/pkg/builder/iptables_builder_impl.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ type IptablesRuleBuilder struct {
4545
cfg *config.Config
4646
}
4747

48-
// NewIptablesBuilders creates a new IptablesRuleBuilder
48+
// NewIptablesRuleBuilder creates a new IptablesRuleBuilder
4949
func NewIptablesRuleBuilder(cfg *config.Config) *IptablesRuleBuilder {
5050
if cfg == nil {
5151
cfg = &config.Config{}
@@ -310,7 +310,7 @@ func (rb *IptablesRuleBuilder) BuildV6Restore() string {
310310
return rb.buildRestore(rb.rules.rulesv6)
311311
}
312312

313-
// getStateFromSave function takes a string in iptables-restore format and returns a map of the tables, chains, and rules.
313+
// GetStateFromSave function takes a string in iptables-restore format and returns a map of the tables, chains, and rules.
314314
// Note that if this function is used to parse iptables-save output, the rules may have changed since they were first applied
315315
// as rules do not necessarily undergo a round-trip through the kernel in the same form.
316316
// Therefore, these rules should not be used for any critical checks.

0 commit comments

Comments
 (0)