fix logic in ShouldUpdateServiceTargets (#57908)

sschepens · web-flow · commit 5ab6df7e5282 · 2025-10-09T05:50:38.000-07:00
diff --git a/pilot/pkg/model/context.go b/pilot/pkg/model/context.go
@@ -560,7 +560,7 @@ func (node *Proxy) SetGatewaysForProxy(ps *PushContext) {
 func (node *Proxy) ShouldUpdateServiceTargets(updates sets.Set[ConfigKey]) bool {
 	// we only care for services which can actually select this proxy
 	for config := range updates {
-		if config.Kind == kind.ServiceEntry || config.Namespace == node.Metadata.Namespace {
+		if config.Kind == kind.ServiceEntry && config.Namespace == node.Metadata.Namespace {
 			return true
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -560,7 +560,7 @@ func (node Proxy) SetGatewaysForProxy(ps PushContext) {`
`560`	`560`	`func (node *Proxy) ShouldUpdateServiceTargets(updates sets.Set[ConfigKey]) bool {`
`561`	`561`	`// we only care for services which can actually select this proxy`
`562`	`562`	`for config := range updates {`
`563`		`- if config.Kind == kind.ServiceEntry \|\| config.Namespace == node.Metadata.Namespace {`
	`563`	`+ if config.Kind == kind.ServiceEntry && config.Namespace == node.Metadata.Namespace {`
`564`	`564`	`return true`
`565`	`565`	`}`
`566`	`566`	`}`