Skip to content

Commit 3456ed8

Browse files
authored
Merge pull request kubernetes-sigs#5668 from serngawy/eks
🐛 Fix eks awsmanagedcontrolplane finalizer permission
2 parents 88cb4b9 + bdb859a commit 3456ed8

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

config/rbac/role.yaml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,13 @@ rules:
116116
- patch
117117
- update
118118
- watch
119+
- apiGroups:
120+
- controlplane.cluster.x-k8s.io
121+
resources:
122+
- awsmanagedcontrolplanes/finalizers
123+
- rosacontrolplanes/finalizers
124+
verbs:
125+
- update
119126
- apiGroups:
120127
- controlplane.cluster.x-k8s.io
121128
resources:
@@ -127,12 +134,6 @@ rules:
127134
- patch
128135
- update
129136
- watch
130-
- apiGroups:
131-
- controlplane.cluster.x-k8s.io
132-
resources:
133-
- rosacontrolplanes/finalizers
134-
verbs:
135-
- update
136137
- apiGroups:
137138
- infrastructure.cluster.x-k8s.io
138139
resources:

controlplane/eks/controllers/awsmanagedcontrolplane_controller.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -205,6 +205,7 @@ func (r *AWSManagedControlPlaneReconciler) SetupWithManager(ctx context.Context,
205205
// +kubebuilder:rbac:groups=infrastructure.cluster.x-k8s.io,resources=awsmachinepools;awsmachinepools/status,verbs=get;list;watch
206206
// +kubebuilder:rbac:groups=controlplane.cluster.x-k8s.io,resources=awsmanagedcontrolplanes,verbs=get;list;watch;update;patch;delete
207207
// +kubebuilder:rbac:groups=controlplane.cluster.x-k8s.io,resources=awsmanagedcontrolplanes/status,verbs=get;update;patch
208+
// +kubebuilder:rbac:groups=controlplane.cluster.x-k8s.io,resources=awsmanagedcontrolplanes/finalizers,verbs=update
208209
// +kubebuilder:rbac:groups=infrastructure.cluster.x-k8s.io,resources=awsclusterroleidentities;awsclusterstaticidentities;awsclustercontrolleridentities,verbs=get;list;watch
209210
// +kubebuilder:rbac:groups=infrastructure.cluster.x-k8s.io,resources=awsmanagedclusters;awsmanagedclusters/status,verbs=get;list;watch
210211

0 commit comments

Comments
 (0)