Skip to content

Commit 0aed54e

Browse files
committed
Add more details about the Progressing condition
"version change" is counted as config changes and thus cluster operators must report Progressing for it. On the contrary, cluster operators should not report Progress ONLY when it owns a DaemonSet that acts on a new node or a node rebooting. It is because it may happen too often in a heaviy-scaled cluster and make Progressing less useful for the clients that hope to use it for Cluster version updating.
1 parent 5d8d667 commit 0aed54e

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

config/v1/types_cluster_operator.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -158,11 +158,13 @@ const (
158158
OperatorAvailable ClusterStatusConditionType = "Available"
159159

160160
// Progressing indicates that the component (operator and all configured operands)
161-
// is actively rolling out new code, propagating config changes, or otherwise
161+
// is actively rolling out new code, propagating config changes (e.g, a version change), or otherwise
162162
// moving from one steady state to another. Operators should not report
163-
// progressing when they are reconciling (without action) a previously known
164-
// state. If the observed cluster state has changed and the component is
165-
// reacting to it (scaling up for instance), Progressing should become true
163+
// Progressing when they are reconciling (without action) a previously known
164+
// state. Operators should not report Progressing only because DaemonSets owned by them
165+
// are adjusting to a new node from cluster scaleup or a node rebooting from cluster upgrade.
166+
// If the observed cluster state has changed and the component is
167+
// reacting to it (updated proxy configuration for instance), Progressing should become true
166168
// since it is moving from one steady state to another.
167169
// A component in a cluster with less than 250 nodes must complete a version
168170
// change within a limited period of time: 90 minutes for Machine Config Operator and 20 minutes for others.

0 commit comments

Comments
 (0)