tooling: add crdify generator to run crdify against CRD changes

Signed-off-by: Bryce Palmer <[email protected]>

Author: everettraven

Makefile

@@ -73,7 +73,7 @@ verify-scripts:
 	hack/verify-payload-featuregates.sh
 
 .PHONY: verify
-verify: verify-scripts lint verify-crd-schema verify-codegen-crds
+verify: verify-scripts lint verify-crd-schema verify-crdify verify-codegen-crds
 
 .PHONY: verify-codegen-crds
 verify-codegen-crds:
@@ -83,6 +83,10 @@ verify-codegen-crds:
 verify-crd-schema:
 	bash -x hack/verify-crd-schema-checker.sh
 
+.PHONY: verify-crdify
+verify-crdify:
+	bash -x hack/verify-crdify.sh
+
 .PHONY: verify-feature-promotion
 verify-feature-promotion:
 	hack/verify-promoted-features-pass-tests.sh

hack/verify-crdify.sh

@@ -0,0 +1,13 @@
+#!/bin/bash
+
+source "$(dirname "${BASH_SOURCE}")/lib/init.sh"
+
+# Use PULL_BASE_REF for CI, otherwise use master unless overriden.
+COMPARISON_BASE=${COMPARISON_BASE:-${PULL_BASE_SHA:-"master"}}
+
+# Use a trap so this gets printed at the end of the log even when we exit early due to an error/failure
+trap 'echo This verifier checks all files that have changed. In some cases you may have changed or renamed a file that \
+already contained api violations, but you are not introducing a new violation.  In such cases it is appropriate to /override the \
+failing CI job.' EXIT
+
+GENERATOR=crdify EXTRA_ARGS=--crdify:comparison-base=${COMPARISON_BASE} ${SCRIPT_ROOT}/hack/update-codegen.sh

tools/codegen/cmd/crdify.go

@@ -0,0 +1,38 @@
+package main
+
+import (
+	"fmt"
+
+	"github.com/openshift/api/tools/codegen/pkg/crdify"
+	"github.com/openshift/api/tools/codegen/pkg/generation"
+	"github.com/spf13/cobra"
+)
+
+var crdifyComparisonBase = "master"
+
+func newCrdifyCommand() *cobra.Command {
+	cmd := &cobra.Command{
+		Use:   "crdify",
+		Short: "crdify verifies compatibility of CRD API schemas",
+		RunE: func(cmd *cobra.Command, args []string) error {
+			genCtx, err := generation.NewContext(generation.Options{
+				BaseDir:          baseDir,
+				APIGroupVersions: apiGroupVersions,
+			})
+			if err != nil {
+				return fmt.Errorf("could not build generation context: %w", err)
+			}
+
+			gen := crdify.NewGenerator(crdify.WithComparisonBase(crdifyComparisonBase))
+
+			return executeGenerators(genCtx, gen)
+		},
+	}
+
+	return cmd
+}
+
+func init() {
+	rootCmd.AddCommand(newCrdifyCommand())
+	rootCmd.PersistentFlags().StringVar(&crdifyComparisonBase, "crdify:comparison-base", crdifyComparisonBase, "base branch/commit to compare against")
+}