Merge pull request #2629 from tssurya/network-connect-feature-gate

openshift-merge-bot[bot] · web-flow · commit 3f584b29ee4a · 2025-12-23T16:35:48.000Z
DevPreview: `NetworkConnect` feature gate
diff --git a/features.md b/features.md
@@ -11,6 +11,7 @@
 | Example2| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | |  |
 | ExternalSnapshotMetadata| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | |  |
 | IngressControllerDynamicConfigurationManager| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | |  |
+| NetworkConnect| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | |  |
 | NewOLMCatalogdAPIV1Metas| | | | <span style="background-color: #519450">Enabled</span> | | | | <span style="background-color: #519450">Enabled</span>  |
 | NewOLMOwnSingleNamespace| | | | <span style="background-color: #519450">Enabled</span> | | | | <span style="background-color: #519450">Enabled</span>  |
 | NewOLMPreflightPermissionChecks| | | | <span style="background-color: #519450">Enabled</span> | | | | <span style="background-color: #519450">Enabled</span>  |
diff --git a/features/features.go b/features/features.go
@@ -187,6 +187,14 @@ var (
 					enableIn(configv1.Default, configv1.OKD, configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
 					mustRegister()
 
+	FeatureGateNetworkConnect = newFeatureGate("NetworkConnect").
+					reportProblemsToJiraComponent("Networking/ovn-kubernetes").
+					contactPerson("tssurya").
+					productScope(ocpSpecific).
+					enhancementPR("https://github.com/ovn-kubernetes/ovn-kubernetes/pull/5246").
+					enableIn(configv1.DevPreviewNoUpgrade).
+					mustRegister()
+
 	FeatureGateAdditionalRoutingCapabilities = newFeatureGate("AdditionalRoutingCapabilities").
 							reportProblemsToJiraComponent("Networking/cluster-network-operator").
 							contactPerson("jcaamano").
@@ -783,7 +791,7 @@ var (
 							mustRegister()
 
 	FeatureGateImageVolume = newFeatureGate("ImageVolume").
-			reportProblemsToJiraComponent("Node").
+				reportProblemsToJiraComponent("Node").
 				contactPerson("haircommander").
 				productScope(kubernetes).
 				enhancementPR("https://github.com/openshift/enhancements/pull/1792").
diff --git a/features/util.go b/features/util.go
@@ -2,9 +2,10 @@ package features
 
 import (
 	"fmt"
-	configv1 "github.com/openshift/api/config/v1"
 	"net/url"
 	"strings"
+
+	configv1 "github.com/openshift/api/config/v1"
 )
 
 // FeatureGateDescription is a golang-only interface used to contains details for a feature gate.
@@ -133,8 +134,10 @@ func (b *featureGateBuilder) register() (configv1.FeatureGateName, error) {
 	case len(b.enhancementPRURL) == 0:
 		return "", fmt.Errorf("FeatureGate/%s is missing an enhancementPR with GA Graduation Criteria like https://github.com/openshift/enhancements/pull/#### or https://github.com/kubernetes/enhancements/issues/####", b.name)
 
-	case !strings.HasPrefix(b.enhancementPRURL, "https://github.com/openshift/enhancements/pull/") && !strings.HasPrefix(b.enhancementPRURL, "https://github.com/kubernetes/enhancements/issues/"):
-		return "", fmt.Errorf("FeatureGate/%s enhancementPR format is incorrect; must be like https://github.com/openshift/enhancements/pull/#### or https://github.com/kubernetes/enhancements/issues/####", b.name)
+	case !strings.HasPrefix(b.enhancementPRURL, "https://github.com/openshift/enhancements/pull/") &&
+		!strings.HasPrefix(b.enhancementPRURL, "https://github.com/kubernetes/enhancements/issues/") &&
+		!strings.HasPrefix(b.enhancementPRURL, "https://github.com/ovn-kubernetes/ovn-kubernetes/pull/"):
+		return "", fmt.Errorf("FeatureGate/%s enhancementPR format is incorrect; must be like https://github.com/openshift/enhancements/pull/#### or https://github.com/kubernetes/enhancements/issues/#### or https://github.com/ovn-kubernetes/ovn-kubernetes/pull/####", b.name)
 
 	case enhancementPRErr != nil:
 		return "", fmt.Errorf("FeatureGate/%s is enhancementPR is invalid: %w", b.name, enhancementPRErr)
diff --git a/payload-manifests/featuregates/featureGate-Hypershift-Default.yaml b/payload-manifests/featuregates/featureGate-Hypershift-Default.yaml
@@ -165,6 +165,9 @@
                     {
                         "name": "MutatingAdmissionPolicy"
                     },
+                    {
+                        "name": "NetworkConnect"
+                    },
                     {
                         "name": "NewOLM"
                     },
diff --git a/payload-manifests/featuregates/featureGate-Hypershift-DevPreviewNoUpgrade.yaml b/payload-manifests/featuregates/featureGate-Hypershift-DevPreviewNoUpgrade.yaml
@@ -262,6 +262,9 @@
                     {
                         "name": "MutatingAdmissionPolicy"
                     },
+                    {
+                        "name": "NetworkConnect"
+                    },
                     {
                         "name": "NetworkDiagnosticsConfig"
                     },
diff --git a/payload-manifests/featuregates/featureGate-Hypershift-OKD.yaml b/payload-manifests/featuregates/featureGate-Hypershift-OKD.yaml
@@ -167,6 +167,9 @@
                     {
                         "name": "MutatingAdmissionPolicy"
                     },
+                    {
+                        "name": "NetworkConnect"
+                    },
                     {
                         "name": "NewOLM"
                     },
diff --git a/payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml b/payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml
@@ -41,6 +41,9 @@
                     {
                         "name": "MultiArchInstallAzure"
                     },
+                    {
+                        "name": "NetworkConnect"
+                    },
                     {
                         "name": "NewOLM"
                     },
diff --git a/payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml b/payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml
@@ -168,6 +168,9 @@
                     {
                         "name": "MutatingAdmissionPolicy"
                     },
+                    {
+                        "name": "NetworkConnect"
+                    },
                     {
                         "name": "NewOLMBoxCutterRuntime"
                     },
diff --git a/payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml b/payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml
@@ -244,6 +244,9 @@
                     {
                         "name": "MutatingAdmissionPolicy"
                     },
+                    {
+                        "name": "NetworkConnect"
+                    },
                     {
                         "name": "NetworkDiagnosticsConfig"
                     },
diff --git a/payload-manifests/featuregates/featureGate-SelfManagedHA-OKD.yaml b/payload-manifests/featuregates/featureGate-SelfManagedHA-OKD.yaml
@@ -170,6 +170,9 @@
                     {
                         "name": "MutatingAdmissionPolicy"
                     },
+                    {
+                        "name": "NetworkConnect"
+                    },
                     {
                         "name": "NewOLMBoxCutterRuntime"
                     },
diff --git a/payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml b/payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml
@@ -44,6 +44,9 @@
                     {
                         "name": "MultiArchInstallAzure"
                     },
+                    {
+                        "name": "NetworkConnect"
+                    },
                     {
                         "name": "NewOLMBoxCutterRuntime"
                     },

Original file line number	Diff line number	Diff line change
`@@ -165,6 +165,9 @@`
`165`	`165`	`{`
`166`	`166`	`"name": "MutatingAdmissionPolicy"`
`167`	`167`	`},`
	`168`	`+ {`
	`169`	`+ "name": "NetworkConnect"`
	`170`	`+ },`
`168`	`171`	`{`
`169`	`172`	`"name": "NewOLM"`
`170`	`173`	`},`
Original file line number	Diff line number	Diff line change
`@@ -262,6 +262,9 @@`
`262`	`262`	`{`
`263`	`263`	`"name": "MutatingAdmissionPolicy"`
`264`	`264`	`},`
	`265`	`+ {`
	`266`	`+ "name": "NetworkConnect"`
	`267`	`+ },`
`265`	`268`	`{`
`266`	`269`	`"name": "NetworkDiagnosticsConfig"`
`267`	`270`	`},`
Original file line number	Diff line number	Diff line change
`@@ -167,6 +167,9 @@`
`167`	`167`	`{`
`168`	`168`	`"name": "MutatingAdmissionPolicy"`
`169`	`169`	`},`
	`170`	`+ {`
	`171`	`+ "name": "NetworkConnect"`
	`172`	`+ },`
`170`	`173`	`{`
`171`	`174`	`"name": "NewOLM"`
`172`	`175`	`},`
Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,9 @@`
`41`	`41`	`{`
`42`	`42`	`"name": "MultiArchInstallAzure"`
`43`	`43`	`},`
	`44`	`+ {`
	`45`	`+ "name": "NetworkConnect"`
	`46`	`+ },`
`44`	`47`	`{`
`45`	`48`	`"name": "NewOLM"`
`46`	`49`	`},`
Original file line number	Diff line number	Diff line change
`@@ -168,6 +168,9 @@`
`168`	`168`	`{`
`169`	`169`	`"name": "MutatingAdmissionPolicy"`
`170`	`170`	`},`
	`171`	`+ {`
	`172`	`+ "name": "NetworkConnect"`
	`173`	`+ },`
`171`	`174`	`{`
`172`	`175`	`"name": "NewOLMBoxCutterRuntime"`
`173`	`176`	`},`
Original file line number	Diff line number	Diff line change
`@@ -244,6 +244,9 @@`
`244`	`244`	`{`
`245`	`245`	`"name": "MutatingAdmissionPolicy"`
`246`	`246`	`},`
	`247`	`+ {`
	`248`	`+ "name": "NetworkConnect"`
	`249`	`+ },`
`247`	`250`	`{`
`248`	`251`	`"name": "NetworkDiagnosticsConfig"`
`249`	`252`	`},`
Original file line number	Diff line number	Diff line change
`@@ -170,6 +170,9 @@`
`170`	`170`	`{`
`171`	`171`	`"name": "MutatingAdmissionPolicy"`
`172`	`172`	`},`
	`173`	`+ {`
	`174`	`+ "name": "NetworkConnect"`
	`175`	`+ },`
`173`	`176`	`{`
`174`	`177`	`"name": "NewOLMBoxCutterRuntime"`
`175`	`178`	`},`