API review: remove BpfApplicationState GetClientObject

Method GetClientObject is not used and removing it removes
the dependency on sigs.k8s.io/controller-runtime/pkg/client

Signed-off-by: Andreas Karis <[email protected]>

Author: andreaskaris

bpfman-operator/apis/v1alpha1/bpf_application_state_types.go

@@ -19,7 +19,6 @@ package v1alpha1
 import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	metav1types "k8s.io/apimachinery/pkg/types"
-	"sigs.k8s.io/controller-runtime/pkg/client"
 )
 
 // +union
@@ -181,10 +180,6 @@ func (an BpfApplicationState) GetConditions() []metav1.Condition {
 	return an.Status.Conditions
 }
 
-func (an BpfApplicationState) GetClientObject() client.Object {
-	return &an
-}
-
 func (anl BpfApplicationStateList) GetItems() []BpfApplicationState {
 	return anl.Items
 }

bpfman-operator/apis/v1alpha1/cluster_bpf_application_state_types.go

@@ -19,7 +19,6 @@ package v1alpha1
 import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	metav1types "k8s.io/apimachinery/pkg/types"
-	"sigs.k8s.io/controller-runtime/pkg/client"
 )
 
 // +union
@@ -232,10 +231,6 @@ func (an ClusterBpfApplicationState) GetConditions() []metav1.Condition {
 	return an.Status.Conditions
 }
 
-func (an ClusterBpfApplicationState) GetClientObject() client.Object {
-	return &an
-}
-
 func (anl ClusterBpfApplicationStateList) GetItems() []ClusterBpfApplicationState {
 	return anl.Items
 }