Skip to content

Commit 8989f44

Browse files
committed
Addressing Claude API review
Signed-off-by: Andreas Karis <[email protected]>
1 parent 046259e commit 8989f44

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

bpfman-operator/apis/v1alpha1/bpf_application_types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ type BpfApplicationProgram struct {
3131
// name is a required field and is the name of the function that is the entry
3232
// point for the eBPF program. name must not be an empty string, must not
3333
// exceed 64 characters in length, must start with alpha characters and must
34-
// only contain alphanumeric characters.
34+
// only contain alphanumeric characters and underscores.
3535
// +required
3636
// +kubebuilder:validation:Pattern="^[a-zA-Z][a-zA-Z0-9_]+."
3737
// +kubebuilder:validation:MinLength=1

bpfman-operator/apis/v1alpha1/cluster_bpf_application_types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ type ClBpfApplicationProgram struct {
7777
// name is a required field and is the name of the function that is the entry
7878
// point for the eBPF program. name must not be an empty string, must not
7979
// exceed 64 characters in length, must start with alpha characters and must
80-
// only contain alphanumeric characters.
80+
// only contain alphanumeric characters and underscores.
8181
// +required
8282
// +kubebuilder:validation:Pattern="^[a-zA-Z][a-zA-Z0-9_]+."
8383
// +kubebuilder:validation:MinLength=1

bpfman-operator/apis/v1alpha1/shared_types.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ type InterfaceDiscovery struct {
5353
}
5454

5555
// InterfaceSelector describes the set of interfaces to attach a program to.
56+
// Exactly one of interfacesDiscoveryConfig, interfaces, or primaryNodeInterface must be specified.
5657
// +kubebuilder:validation:MaxProperties=1
5758
// +kubebuilder:validation:MinProperties=1
5859
type InterfaceSelector struct {
@@ -229,6 +230,7 @@ const (
229230
)
230231

231232
// ByteCodeSelector defines the various ways to reference BPF bytecode objects.
233+
// Exactly one of image or path must be specified.
232234
// +kubebuilder:validation:MaxProperties=1
233235
// +kubebuilder:validation:MinProperties=1
234236
type ByteCodeSelector struct {
@@ -238,7 +240,7 @@ type ByteCodeSelector struct {
238240
Image *ByteCodeImage `json:"image,omitempty"`
239241

240242
// path is an optional field and used to specify a bytecode object file via
241-
// filepath on a Kubernetes node.
243+
// filepath on a Kubernetes node. The path must a a valid absolute path.
242244
// +optional
243245
// +kubebuilder:validation:Pattern=`^(/[^/\0]+)+/?$`
244246
Path *string `json:"path,omitempty"`

0 commit comments

Comments
 (0)