Merge pull request #2462 from chrischdi/pr-machinehealthcheck-maxunhealthy-godoc

openshift-merge-bot[bot] · web-flow · commit a638ff2e96fb · 2025-09-01T12:08:40.000Z
OCPBUGS-60901: Add default value for MachineHealthCheck's maxUnhealthy to the description
diff --git a/machine/v1beta1/types_machinehealthcheck.go b/machine/v1beta1/types_machinehealthcheck.go
@@ -76,6 +76,7 @@ type MachineHealthCheckSpec struct {
 	// Expects either a postive integer value or a percentage value.
 	// Percentage values must be positive whole numbers and are capped at 100%.
 	// Both 0 and 0% are valid and will block all remediation.
+	// Defaults to 100% if not set.
 	// +kubebuilder:default:="100%"
 	// +kubebuilder:validation:XIntOrString
 	// +kubebuilder:validation:Pattern="^((100|[0-9]{1,2})%|[0-9]+)$"
diff --git a/machine/v1beta1/zz_generated.crd-manifests/0000_10_machine-api_01_machinehealthchecks.crd.yaml b/machine/v1beta1/zz_generated.crd-manifests/0000_10_machine-api_01_machinehealthchecks.crd.yaml
@@ -71,6 +71,7 @@ spec:
                   Expects either a postive integer value or a percentage value.
                   Percentage values must be positive whole numbers and are capped at 100%.
                   Both 0 and 0% are valid and will block all remediation.
+                  Defaults to 100% if not set.
                 pattern: ^((100|[0-9]{1,2})%|[0-9]+)$
                 x-kubernetes-int-or-string: true
               nodeStartupTimeout:
diff --git a/machine/v1beta1/zz_generated.featuregated-crd-manifests/machinehealthchecks.machine.openshift.io/AAA_ungated.yaml b/machine/v1beta1/zz_generated.featuregated-crd-manifests/machinehealthchecks.machine.openshift.io/AAA_ungated.yaml
@@ -74,6 +74,7 @@ spec:
                   Expects either a postive integer value or a percentage value.
                   Percentage values must be positive whole numbers and are capped at 100%.
                   Both 0 and 0% are valid and will block all remediation.
+                  Defaults to 100% if not set.
                 pattern: ^((100|[0-9]{1,2})%|[0-9]+)$
                 x-kubernetes-int-or-string: true
               nodeStartupTimeout:
diff --git a/machine/v1beta1/zz_generated.swagger_doc_generated.go b/machine/v1beta1/zz_generated.swagger_doc_generated.go
diff --git a/openapi/generated_openapi/zz_generated.openapi.go b/openapi/generated_openapi/zz_generated.openapi.go
diff --git a/openapi/openapi.json b/openapi/openapi.json
@@ -23243,7 +23243,7 @@
       ],
       "properties": {
         "maxUnhealthy": {
-          "description": "Any farther remediation is only allowed if at most \"MaxUnhealthy\" machines selected by \"selector\" are not healthy. Expects either a postive integer value or a percentage value. Percentage values must be positive whole numbers and are capped at 100%. Both 0 and 0% are valid and will block all remediation.",
+          "description": "Any farther remediation is only allowed if at most \"MaxUnhealthy\" machines selected by \"selector\" are not healthy. Expects either a postive integer value or a percentage value. Percentage values must be positive whole numbers and are capped at 100%. Both 0 and 0% are valid and will block all remediation. Defaults to 100% if not set.",
           "$ref": "#/definitions/io.k8s.apimachinery.pkg.util.intstr.IntOrString"
         },
         "nodeStartupTimeout": {
