Make internalPort optional to resolve API compatibility error

- Changed internalPort from required to optional (*int32 with omitempty)
- This resolves the NoNewRequiredFields API compatibility violation
- Updated test case to reflect optional field behavior
- Users can now omit internalPort for custom deployments
- Regenerated deepcopy functions and OpenAPI schemas

Author: sebrandon1

config/v1/tests/apiservers.config.openshift.io/HTTP01ChallengeProxy.yaml

@@ -104,15 +104,23 @@ tests:
             customDeployment:
               internalPort: 8888
       expectedError: "customDeployment is required when mode is CustomDeployment and forbidden otherwise"
-    - name: Should reject CustomDeployment mode with customDeployment but missing internalPort
+    - name: Should be able to create CustomDeployment mode with empty customDeployment (internalPort optional)
       initial: |
         apiVersion: config.openshift.io/v1
         kind: APIServer
         spec:
           http01ChallengeProxy:
             mode: CustomDeployment
             customDeployment: {}
-      expectedError: "spec.http01ChallengeProxy.customDeployment.internalPort: Required value"
+      expected: |
+        apiVersion: config.openshift.io/v1
+        kind: APIServer
+        spec:
+          audit:
+            profile: Default
+          http01ChallengeProxy:
+            mode: CustomDeployment
+            customDeployment: {}
     - name: Should reject CustomDeployment mode with port below minimum 1023
       initial: |
         apiVersion: config.openshift.io/v1

config/v1/types_apiserver.go

@@ -263,11 +263,12 @@ type HTTP01ChallengeProxySpec struct {
 type HTTP01ChallengeProxyCustomDeploymentSpec struct {
 	// internalPort specifies the internal port used by the proxy service.
 	// Valid values are 1024-65535.
-	// This port must be specified to avoid conflicts with other workloads on the host.
+	// When not specified for CustomDeployment mode, users should ensure their chosen port
+	// does not conflict with other workloads on the host.
 	// +kubebuilder:validation:Minimum=1024
 	// +kubebuilder:validation:Maximum=65535
-	// +required
-	InternalPort int32 `json:"internalPort"`
+	// +optional
+	InternalPort *int32 `json:"internalPort,omitempty"`
 }
 
 type APIServerStatus struct {

config/v1/zz_generated.deepcopy.go

@@ -6893,15 +6893,11 @@
     },
     "com.github.openshift.api.config.v1.HTTP01ChallengeProxyCustomDeploymentSpec": {
       "type": "object",
-      "required": [
-        "internalPort"
-      ],
       "properties": {
         "internalPort": {
-          "description": "internalPort specifies the internal port used by the proxy service. Valid values are 1024-65535. This port must be specified to avoid conflicts with other workloads on the host.",
+          "description": "internalPort specifies the internal port used by the proxy service. Valid values are 1024-65535. When not specified for CustomDeployment mode, users should ensure their chosen port does not conflict with other workloads on the host.",
           "type": "integer",
-          "format": "int32",
-          "default": 0
+          "format": "int32"
         }
       }
     },