fix: integration tests

Signed-off-by: Ondrej Pokorny <[email protected]>

Author: opokornyy

config/v1/tests/insightsdatagathers.config.openshift.io/InsightsConfig.yaml

@@ -9,11 +9,23 @@ tests:
       initial: |
         apiVersion: config.openshift.io/v1
         kind: InsightsDataGather
-        spec: {} # No spec is required for a InsightsDataGather
+        spec:
+          gatherConfig:
+              gatherers:
+                mode: All
       expected: |
+        apiVersion: config.openshift.io/v1
+        kind: InsightsDataGather
+        spec:
+          gatherConfig:
+              gatherers:
+                mode: All
+    - name: InsightsDataGather without the spec should not be created
+      initial: |
         apiVersion: config.openshift.io/v1
         kind: InsightsDataGather
         spec: {}
+      expectedError: "spec: Invalid value: 0: spec in body should have at least 1 properties"
     - name: Should be able to create InsightsDataGather with a storage and PersistentVolume
       initial: |
         apiVersion: config.openshift.io/v1

insights/v1/tests/datagathers.insights.openshift.io/InsightsOnDemandDataGather.yaml

@@ -262,7 +262,7 @@ tests:
           relatedObjects:
             - name: periodic-job-xyz
               resource: "pods"
-              group: ""
+              group: "group"
               namespace: "openshift-insights"
       updated: |
         apiVersion: insights.openshift.io/v1
@@ -273,7 +273,7 @@ tests:
           relatedObjects:
             - name: periodic-job-xyz
               resource: "pods"
-              group: ""
+              group: "group"
               namespace: "openshift-insights"
       expected: |
         apiVersion: insights.openshift.io/v1
@@ -283,7 +283,7 @@ tests:
           insightsRequestID: testing-xyz
           relatedObjects:
             - name: periodic-job-xyz
-              group: ""
+              group: "group"
               resource: "pods"
               namespace: "openshift-insights"
     - name: insightsRequestID cannot be removed from status
@@ -295,7 +295,7 @@ tests:
           insightsRequestID: testing-xyz
           relatedObjects:
             - name: periodic-job-xyz
-              group: ""
+              group: "group"
               resource: "pods"
               namespace: "openshift-insights"
       updated: |
@@ -305,7 +305,7 @@ tests:
         status: 
           relatedObjects:
             - name: periodic-job-xyz
-              group: ""
+              group: "group"
               resource: "pods"
               namespace: "openshift-insights"
       expectedStatusError: 'status: Invalid value: "object": cannot remove insightsRequestID attribute from status'
@@ -318,7 +318,7 @@ tests:
           insightsRequestID: testing-xyz
           relatedObjects:
             - name: periodic-job-xyz
-              group: ""
+              group: "group"
               resource: "pods"
               namespace: "openshift-insights"
       updated: |
@@ -329,7 +329,7 @@ tests:
           insightsRequestID: testing-xyz-updated
           relatedObjects:
             - name: periodic-job-xyz
-              group: ""
+              group: "group"
               resource: "pods"
               namespace: "openshift-insights"
       expectedStatusError: 'Invalid value: "string": insightsRequestID is immutable once set'
@@ -342,7 +342,7 @@ tests:
           finishTime: 2023-03-13T11:34:06Z
           relatedObjects:
             - name: periodic-job-xyz
-              group: ""
+              group: "group"
               resource: "pods"
               namespace: "openshift-insights"
       updated: |
@@ -352,7 +352,7 @@ tests:
         status: 
           relatedObjects:
             - name: periodic-job-xyz
-              group: ""
+              group: "group"
               resource: "pods"
               namespace: "openshift-insights"
       expectedStatusError: 'status: Invalid value: "object": cannot remove finishTime attribute from status'