fix: totalRisk and group fields

opokornyy · opokornyy · commit e34bacd8062a · 2025-09-01T13:24:56.000+02:00
Signed-off-by: Ondrej Pokorny &lt;opokorny@redhat.com&gt;
diff --git a/insights/v1/types_insights.go b/insights/v1/types_insights.go
@@ -359,7 +359,7 @@ type HealthCheck struct {
 	Description string `json:"description,omitempty"`
 	// totalRisk is the required field of the healthcheck.
 	// It is indicator of the total risk posed by the detected issue; combination of impact and likelihood.
-	// Allowed values are Low, Medium, Important and Critical.
+	// Allowed values are Low, Moderate, Important and Critical.
 	// The value represents the severity of the issue.
 	// +required
 	TotalRisk TotalRisk `json:"totalRisk,omitempty"`
@@ -391,10 +391,10 @@ type ObjectReference struct {
 	// It must be at most 253 characters in length, and must consist only of lower case alphanumeric characters, '-' and '.', and must start with an alphabetic character and end with an alphanumeric character.
 	// Example: "", "apps", "build.openshift.io", etc.
 	// +kubebuilder:validation:XValidation:rule="self.size() == 0 || !format.dns1123Subdomain().validate(self).hasValue()",message="a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start with an alphabetic character and end with an alphanumeric character."
-	// +kubebuilder:validation:MinLength=1
+	// +kubebuilder:validation:MinLength=0
 	// +kubebuilder:validation:MaxLength=253
 	// +required
-	Group string `json:"group,omitempty"`
+	Group *string `json:"group,omitempty"`
 	// resource is required field of the type that is being referenced and follows the DNS1035 format.
 	// It is normally the plural form of the resource kind in lowercase.
 	// It must be at most 63 characters in length, and must must consist of only lowercase alphanumeric characters and hyphens, and must start with an alphabetic character and end with an alphanumeric character.
diff --git a/insights/v1/zz_generated.crd-manifests/0000_10_insights_01_datagathers-CustomNoUpgrade.crd.yaml b/insights/v1/zz_generated.crd-manifests/0000_10_insights_01_datagathers-CustomNoUpgrade.crd.yaml
@@ -476,7 +476,7 @@ spec:
                           description: |-
                             totalRisk is the required field of the healthcheck.
                             It is indicator of the total risk posed by the detected issue; combination of impact and likelihood.
-                            Allowed values are Low, Medium, Important and Critical.
+                            Allowed values are Low, Moderate, Important and Critical.
                             The value represents the severity of the issue.
                           enum:
                           - Low
@@ -533,7 +533,7 @@ spec:
                         It must be at most 253 characters in length, and must consist only of lower case alphanumeric characters, '-' and '.', and must start with an alphabetic character and end with an alphanumeric character.
                         Example: "", "apps", "build.openshift.io", etc.
                       maxLength: 253
-                      minLength: 1
+                      minLength: 0
                       type: string
                       x-kubernetes-validations:
                       - message: a lowercase RFC 1123 subdomain must consist of lower
diff --git a/insights/v1/zz_generated.crd-manifests/0000_10_insights_01_datagathers-DevPreviewNoUpgrade.crd.yaml b/insights/v1/zz_generated.crd-manifests/0000_10_insights_01_datagathers-DevPreviewNoUpgrade.crd.yaml
@@ -476,7 +476,7 @@ spec:
                           description: |-
                             totalRisk is the required field of the healthcheck.
                             It is indicator of the total risk posed by the detected issue; combination of impact and likelihood.
-                            Allowed values are Low, Medium, Important and Critical.
+                            Allowed values are Low, Moderate, Important and Critical.
                             The value represents the severity of the issue.
                           enum:
                           - Low
@@ -533,7 +533,7 @@ spec:
                         It must be at most 253 characters in length, and must consist only of lower case alphanumeric characters, '-' and '.', and must start with an alphabetic character and end with an alphanumeric character.
                         Example: "", "apps", "build.openshift.io", etc.
                       maxLength: 253
-                      minLength: 1
+                      minLength: 0
                       type: string
                       x-kubernetes-validations:
                       - message: a lowercase RFC 1123 subdomain must consist of lower
diff --git a/insights/v1/zz_generated.crd-manifests/0000_10_insights_01_datagathers-TechPreviewNoUpgrade.crd.yaml b/insights/v1/zz_generated.crd-manifests/0000_10_insights_01_datagathers-TechPreviewNoUpgrade.crd.yaml
@@ -476,7 +476,7 @@ spec:
                           description: |-
                             totalRisk is the required field of the healthcheck.
                             It is indicator of the total risk posed by the detected issue; combination of impact and likelihood.
-                            Allowed values are Low, Medium, Important and Critical.
+                            Allowed values are Low, Moderate, Important and Critical.
                             The value represents the severity of the issue.
                           enum:
                           - Low
@@ -533,7 +533,7 @@ spec:
                         It must be at most 253 characters in length, and must consist only of lower case alphanumeric characters, '-' and '.', and must start with an alphabetic character and end with an alphanumeric character.
                         Example: "", "apps", "build.openshift.io", etc.
                       maxLength: 253
-                      minLength: 1
+                      minLength: 0
                       type: string
                       x-kubernetes-validations:
                       - message: a lowercase RFC 1123 subdomain must consist of lower
diff --git a/insights/v1/zz_generated.deepcopy.go b/insights/v1/zz_generated.deepcopy.go
diff --git a/insights/v1/zz_generated.featuregated-crd-manifests/datagathers.insights.openshift.io/InsightsOnDemandDataGather.yaml b/insights/v1/zz_generated.featuregated-crd-manifests/datagathers.insights.openshift.io/InsightsOnDemandDataGather.yaml
@@ -476,7 +476,7 @@ spec:
                           description: |-
                             totalRisk is the required field of the healthcheck.
                             It is indicator of the total risk posed by the detected issue; combination of impact and likelihood.
-                            Allowed values are Low, Medium, Important and Critical.
+                            Allowed values are Low, Moderate, Important and Critical.
                             The value represents the severity of the issue.
                           enum:
                           - Low
@@ -533,7 +533,7 @@ spec:
                         It must be at most 253 characters in length, and must consist only of lower case alphanumeric characters, '-' and '.', and must start with an alphabetic character and end with an alphanumeric character.
                         Example: "", "apps", "build.openshift.io", etc.
                       maxLength: 253
-                      minLength: 1
+                      minLength: 0
                       type: string
                       x-kubernetes-validations:
                       - message: a lowercase RFC 1123 subdomain must consist of lower
diff --git a/insights/v1/zz_generated.swagger_doc_generated.go b/insights/v1/zz_generated.swagger_doc_generated.go
diff --git a/openapi/generated_openapi/zz_generated.openapi.go b/openapi/generated_openapi/zz_generated.openapi.go
diff --git a/openapi/openapi.json b/openapi/openapi.json
@@ -16136,7 +16136,7 @@
           "type": "string"
         },
         "totalRisk": {
-          "description": "totalRisk is the required field of the healthcheck. It is indicator of the total risk posed by the detected issue; combination of impact and likelihood. Allowed values are Low, Medium, Important and Critical. The value represents the severity of the issue.",
+          "description": "totalRisk is the required field of the healthcheck. It is indicator of the total risk posed by the detected issue; combination of impact and likelihood. Allowed values are Low, Moderate, Important and Critical. The value represents the severity of the issue.",
           "type": "string"
         }
       }

Original file line number	Diff line number	Diff line change
`@@ -16136,7 +16136,7 @@`
`16136`	`16136`	`"type": "string"`
`16137`	`16137`	`},`
`16138`	`16138`	`"totalRisk": {`
`16139`		`- "description": "totalRisk is the required field of the healthcheck. It is indicator of the total risk posed by the detected issue; combination of impact and likelihood. Allowed values are Low, Medium, Important and Critical. The value represents the severity of the issue.",`
	`16139`	`+ "description": "totalRisk is the required field of the healthcheck. It is indicator of the total risk posed by the detected issue; combination of impact and likelihood. Allowed values are Low, Moderate, Important and Critical. The value represents the severity of the issue.",`
`16140`	`16140`	`"type": "string"`
`16141`	`16141`	`}`
`16142`	`16142`	`}`