Skip to content

Commit c5569c1

Browse files
authored
add member name as key when comparing pool members (kubernetes#2008)
1 parent 297a188 commit c5569c1

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pkg/openstack/loadbalancer.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1285,7 +1285,7 @@ func (lbaas *LbaasV2) ensureOctaviaPool(lbID string, name string, listener *list
12851285
klog.Errorf("failed to get members in the pool %s: %v", pool.ID, err)
12861286
}
12871287
for _, m := range poolMembers {
1288-
curMembers.Insert(fmt.Sprintf("%s-%d-%d", m.Address, m.ProtocolPort, m.MonitorPort))
1288+
curMembers.Insert(fmt.Sprintf("%s-%s-%d-%d", m.Name, m.Address, m.ProtocolPort, m.MonitorPort))
12891289
}
12901290

12911291
members, newMembers, err := lbaas.buildBatchUpdateMemberOpts(port, nodes, svcConf)
@@ -1364,7 +1364,7 @@ func (lbaas *LbaasV2) buildBatchUpdateMemberOpts(port corev1.ServicePort, nodes
13641364
member.MonitorPort = &svcConf.healthCheckNodePort
13651365
}
13661366
members = append(members, member)
1367-
newMembers.Insert(fmt.Sprintf("%s-%d-%d", addr, member.ProtocolPort, svcConf.healthCheckNodePort))
1367+
newMembers.Insert(fmt.Sprintf("%s-%s-%d-%d", node.Name, addr, member.ProtocolPort, svcConf.healthCheckNodePort))
13681368
}
13691369
return members, newMembers, nil
13701370
}

0 commit comments

Comments
 (0)