NO-ISSUE: Fix agent cluster controller orphaning tests (#148)

While updating the dependencies of the project I noticed that these two
tests started to fail because the agent cluster object doesn't have the
`apiVersion` and `kind` fields populated, and that is used by the new
versions of the functions that compare owner references. But when I
fixed that the test started to fail because the setup of the agent
cluster isn't correct for the test: it needs to have a valid
`status.clusterDeploymentRef` and a valid `spec.controlPlaneEndpoint`,
otherwise the reconciler will not do the orphaning logic, or will reject
the object completely. This patch fixes those tests so that they work
now and will also work when updated to newer versions of the
dependencies.

Signed-off-by: Juan Hernandez <[email protected]>

Author: jhernand

controllers/agentcluster_controller_test.go

@@ -42,6 +42,10 @@ func newAgentClusterRequest(agentCluster *capiproviderv1.AgentCluster) ctrl.Requ
 
 func newAgentCluster(name, namespace string, spec capiproviderv1.AgentClusterSpec) *capiproviderv1.AgentCluster {
 	return &capiproviderv1.AgentCluster{
+		TypeMeta: metav1.TypeMeta{
+			Kind:       "AgentCluster",
+			APIVersion: capiproviderv1.GroupVersion.String(),
+		},
 		ObjectMeta: metav1.ObjectMeta{
 			Name:      name,
 			Namespace: namespace,
@@ -334,7 +338,17 @@ var _ = Describe("agentcluster reconcile", func() {
 			Expect(clusterutilv1.IsOwnedByObject(clusterDeployment, agentCluster)).To(BeFalse())
 		})
 		It("recovers its cluster deployment when unpaused", func() {
+			// For this test the agent cluster needs to have a valid cluster deployment reference, otherwise
+			// the reconcilation will not orphan it. It also needs a valid control plane endpoint because
+			// that is verified by the reconciler.
 			agentCluster := createDefaultResources(ctx, c, clusterName, testNamespace, baseDomain, pullSecret, kubeconfig, kubeadminPassword)
+			agentCluster.Spec.ControlPlaneEndpoint.Host = "1.2.3.4"
+			agentCluster.Spec.ControlPlaneEndpoint.Port = 1234
+			Expect(c.Update(ctx, agentCluster)).To(Succeed())
+			agentCluster.Status.ClusterDeploymentRef.Namespace = testNamespace
+			agentCluster.Status.ClusterDeploymentRef.Name = clusterName
+			Expect(c.Status().Update(ctx, agentCluster)).To(Succeed())
+
 			createClusterDeployment(c, ctx, agentCluster, clusterName, baseDomain, pullSecret)
 
 			clusterDeployment := &hivev1.ClusterDeployment{}
@@ -362,7 +376,13 @@ var _ = Describe("agentcluster reconcile", func() {
 			Expect(clusterutilv1.IsOwnedByObject(clusterDeployment, agentCluster)).To(BeTrue())
 		})
 		It("doesn't delete the cluster deployment when paused and agent cluster gets deleted", func() {
+			// For this test the agent cluster needs to have a valid cluster deployment reference, otherwise
+			// the reconcilation will not orphan it.
 			agentCluster := createDefaultResources(ctx, c, clusterName, testNamespace, baseDomain, pullSecret, kubeconfig, kubeadminPassword)
+			agentCluster.Status.ClusterDeploymentRef.Namespace = testNamespace
+			agentCluster.Status.ClusterDeploymentRef.Name = clusterName
+			Expect(c.Status().Update(ctx, agentCluster)).To(Succeed())
+
 			createClusterDeployment(c, ctx, agentCluster, clusterName, baseDomain, pullSecret)
 
 			clusterDeployment := &hivev1.ClusterDeployment{}