Add more condition logic for failed VMs

Signed-off-by: David Vossel <[email protected]>

Author: davidvossel

api/v1alpha1/condition_consts.go

@@ -33,6 +33,10 @@ const (
 	// WaitingForBootstrapDataReason (Severity=Info) documents a KubevirtMachine waiting for the bootstrap
 	// script to be ready before starting to create the VM that provides the KubevirtMachine infrastructure.
 	WaitingForBootstrapDataReason = "WaitingForBootstrapData"
+
+	// VMCreateFailed (Severity=Error) documents a KubevirtMachine that is unable to create the
+	// corresponding VM object.
+	VMCreateFailedReason = "VMCreateFailed"
 )
 
 const (

controllers/kubevirtmachine_controller.go

@@ -20,9 +20,10 @@ import (
 	gocontext "context"
 	"fmt"
 	"regexp"
-	"sigs.k8s.io/controller-runtime/pkg/builder"
 	"time"
 
+	"sigs.k8s.io/controller-runtime/pkg/builder"
+
 	"github.com/pkg/errors"
 	"gopkg.in/yaml.v3"
 	corev1 "k8s.io/api/core/v1"
@@ -264,6 +265,7 @@ func (r *KubevirtMachineReconciler) reconcileNormal(ctx *context.MachineContext)
 	if !isTerminal && !externalMachine.Exists() {
 		ctx.KubevirtMachine.Status.Ready = false
 		if err := externalMachine.Create(ctx.Context); err != nil {
+			conditions.MarkFalse(ctx.KubevirtMachine, infrav1.VMProvisionedCondition, infrav1.VMCreateFailedReason, clusterv1.ConditionSeverityError, fmt.Sprintf("Failed vm creation: %v", err))
 			return ctrl.Result{}, errors.Wrap(err, "failed to create VM instance")
 		}
 		ctx.Logger.Info("VM Created, waiting on vm to be provisioned.")