Skip to content

Commit 94a369b

Browse files
committed
Remove the setup counter from the KVMachine ready status
Cluster-API takes the reason and the message from the infra-machine (in our case, the KubeVirtMachine) `Ready` condition, into `Machine` `InfrastructureReady` condition. Currently the text is something like `"0 of 2 completed"`. This is not very informative. This PR changes the behavior so now the KV Machine Ready condition will include both the reason and the message from the failed condition. That way, the cluster-api `InfrastructureReady` condition, will also contain the same reason and message. This will make the actual issue, if exists, to more accessible to the user. Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
1 parent 1ab9fc5 commit 94a369b

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

pkg/context/machine_context.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ func (c *MachineContext) PatchKubevirtMachine(patchHelper *patch.Helper) error {
6666
infrav1.VMProvisionedCondition,
6767
infrav1.BootstrapExecSucceededCondition,
6868
),
69-
conditions.WithStepCounterIf(c.KubevirtMachine.ObjectMeta.DeletionTimestamp.IsZero()),
7069
)
7170

7271
// Patch the object, ignoring conflicts on the conditions owned by this controller.

0 commit comments

Comments
 (0)