Merge pull request kubernetes-sigs#280 from nunnatsa/dv-import-fail-reason

Add new reason for failed vm

Author: k8s-ci-robot

pkg/kubevirt/machine.go

@@ -283,15 +283,20 @@ func (m *Machine) getDVNotProvisionedReason(dv *cdiv1.DataVolume) (string, strin
 	case cdiv1.Failed:
 		return "DVFailed", msg, true
 	default:
+		reason := "DVNotReady"
 		for _, dvCond := range dv.Status.Conditions {
 			if dvCond.Type == cdiv1.DataVolumeRunning {
 				if dvCond.Status == corev1.ConditionFalse {
+					if dvCond.Reason == "ImagePullFailed" {
+						reason = "DVImagePullFailed"
+					}
+
 					msg = fmt.Sprintf("DataVolume %s import is not running: %s", dv.Name, dvCond.Message)
 				}
 				break
 			}
 		}
-		return "DVNotReady", msg, true
+		return reason, msg, true
 	}
 }
 

pkg/kubevirt/machine_test.go

@@ -956,6 +956,19 @@ var _ = Describe("check GetVMNotReadyReason", func() {
 				Conditions: []cdiv1.DataVolumeCondition{},
 			},
 		}, "DVNotReady", "is not ready; Phase: ImportInProgress"),
+		Entry("dv with Running condition and reason = 'ImagePullFailed'", &kubevirtv1.VirtualMachine{}, &cdiv1.DataVolume{
+			Status: cdiv1.DataVolumeStatus{
+				Phase: cdiv1.ImportInProgress,
+				Conditions: []cdiv1.DataVolumeCondition{
+					{
+						Type:    cdiv1.DataVolumeRunning,
+						Status:  corev1.ConditionFalse,
+						Reason:  "ImagePullFailed",
+						Message: "test message",
+					},
+				},
+			},
+		}, "DVImagePullFailed", "test message"),
 	)
 })