cloud: Better error message on image lookup failure

Currently, if cluster-api fails to find an image during machine creation
it fails with the following, rather unhelpful error:

  "Reconciler error" err="no images were found with the given image filter: {<nil> 0xc000558880}" ...

Improve our error messages so we get something slightly more useful.

  "Reconciler error" err="no images were found with the given image filter: name=foo, tags=[]" ...

Signed-off-by: Stephen Finucane <[email protected]>

Author: stephenfin

pkg/cloud/services/compute/instance.go

@@ -346,12 +346,20 @@ func (s *Service) GetImageID(image infrav1.ImageParam) (string, error) {
 
 	switch len(allImages) {
 	case 0:
-		return "", fmt.Errorf("no images were found with the given image filter: %v", image)
+		var name string
+		if image.Filter.Name != nil {
+			name = *image.Filter.Name
+		}
+		return "", fmt.Errorf("no images were found with the given image filter: name=%v, tags=%v", name, image.Filter.Tags)
 	case 1:
 		return allImages[0].ID, nil
 	default:
 		// this should never happen
-		return "", fmt.Errorf("too many images were found with the given image filter: %v", image)
+		var name string
+		if image.Filter.Name != nil {
+			name = *image.Filter.Name
+		}
+		return "", fmt.Errorf("too many images were found with the given image filter: name=%v, tags=%v", name, image.Filter.Tags)
 	}
 }