openshift: return an error if a machine doesn't have ports

EmilienM · EmilienM · commit a8678cb72179 · 2024-11-06T21:16:24.000-05:00
diff --git a/openshift/pkg/infraclustercontroller/openstackcluster.go b/openshift/pkg/infraclustercontroller/openstackcluster.go
@@ -384,6 +384,9 @@ func (r *OpenShiftClusterReconciler) getDefaultSubnetFromMachines(ctx context.Co
 		if err != nil {
 			return nil, fmt.Errorf("listing ports for instance %s: %w", instanceID, err)
 		}
+		if len(ports) == 0 {
+			return nil, fmt.Errorf("no ports found for instance %s", instanceID)
+		}
 		for _, port := range ports {
 			log := log.WithValues("port", port.ID)
 

Original file line number	Diff line number	Diff line change
`@@ -384,6 +384,9 @@ func (r *OpenShiftClusterReconciler) getDefaultSubnetFromMachines(ctx context.Co`
`384`	`384`	`if err != nil {`
`385`	`385`	`return nil, fmt.Errorf("listing ports for instance %s: %w", instanceID, err)`
`386`	`386`	`}`
	`387`	`+ if len(ports) == 0 {`
	`388`	`+ return nil, fmt.Errorf("no ports found for instance %s", instanceID)`
	`389`	`+ }`
`387`	`390`	`for _, port := range ports {`
`388`	`391`	`log := log.WithValues("port", port.ID)`
`389`	`392`