Skip to content

Commit fd02389

Browse files
lentzi90k8s-infra-cherrypick-robot
authored andcommitted
E2E: Use CAPI production images
Use CAPI production images instead of from GCR. Don't prepull cert-manager. We always let these images get out of sync, causing us to pull double instead of saving anything. We end up with different tags in e2e_conf.yaml and in the Makefile. Additionally, CAPI may change what version is installed by clusterctl by default, causing us to pull *two* wrong versions and then install a third if we don't remember to check when bumping CAPI. Signed-off-by: Lennart Jern <[email protected]>
1 parent 4fd334b commit fd02389

File tree

2 files changed

+6
-18
lines changed

2 files changed

+6
-18
lines changed

Makefile

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -209,12 +209,9 @@ e2e-image: docker-build
209209

210210
# Pull all the images references in test/e2e/data/e2e_conf.yaml
211211
test-e2e-image-prerequisites:
212-
docker pull gcr.io/k8s-staging-cluster-api/cluster-api-controller:v1.6.0
213-
docker pull gcr.io/k8s-staging-cluster-api/kubeadm-bootstrap-controller:v1.6.0
214-
docker pull gcr.io/k8s-staging-cluster-api/kubeadm-control-plane-controller:v1.6.0
215-
docker pull quay.io/jetstack/cert-manager-cainjector:v1.12.1
216-
docker pull quay.io/jetstack/cert-manager-webhook:v1.12.1
217-
docker pull quay.io/jetstack/cert-manager-controller:v1.12.1
212+
docker pull registry.k8s.io/cluster-api/cluster-api-controller:v1.8.5
213+
docker pull registry.k8s.io/cluster-api/kubeadm-bootstrap-controller:v1.8.5
214+
docker pull registry.k8s.io/cluster-api/kubeadm-control-plane-controller:v1.8.5
218215

219216
CONFORMANCE_E2E_ARGS ?= -kubetest.config-file=$(KUBETEST_CONF_PATH)
220217
CONFORMANCE_E2E_ARGS += $(E2E_ARGS)

test/e2e/data/e2e_conf.yaml

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
---
22
# E2E test scenario using local dev images and manifests built from the source tree for following providers:
3-
# - cluster-api
4-
# - bootstrap kubeadm
5-
# - control-plane kubeadm
63
# - openstack
74

85
# To run tests, run the following from the root of this repository.
@@ -12,21 +9,15 @@
129
managementClusterName: capo-e2e
1310

1411
images:
15-
- name: gcr.io/k8s-staging-cluster-api/cluster-api-controller:v1.8.5
12+
- name: registry.k8s.io/cluster-api/cluster-api-controller:v1.8.5
1613
loadBehavior: tryLoad
17-
- name: gcr.io/k8s-staging-cluster-api/kubeadm-bootstrap-controller:v1.8.5
14+
- name: registry.k8s.io/cluster-api/kubeadm-bootstrap-controller:v1.8.5
1815
loadBehavior: tryLoad
19-
- name: gcr.io/k8s-staging-cluster-api/kubeadm-control-plane-controller:v1.8.5
16+
- name: registry.k8s.io/cluster-api/kubeadm-control-plane-controller:v1.8.5
2017
loadBehavior: tryLoad
2118
# Use local dev images built source tree;
2219
- name: gcr.io/k8s-staging-capi-openstack/capi-openstack-controller:e2e
2320
loadBehavior: mustLoad
24-
- name: quay.io/jetstack/cert-manager-cainjector:v1.14.5
25-
loadBehavior: tryLoad
26-
- name: quay.io/jetstack/cert-manager-webhook:v1.14.5
27-
loadBehavior: tryLoad
28-
- name: quay.io/jetstack/cert-manager-controller:v1.14.5
29-
loadBehavior: tryLoad
3021

3122
providers:
3223
- name: cluster-api

0 commit comments

Comments
 (0)