fix: add os.O_SYNC flag to prevent empty revision.json on ungraceful shutdown

clobrano · clobrano · commit a3d111a30976 · 2025-10-09T10:37:24.000+02:00
diff --git a/pkg/cmd/rev/rev.go b/pkg/cmd/rev/rev.go
@@ -189,7 +189,7 @@ func trySaveRevision(ctx context.Context, endpoints []string, outputFile string,
 	}
 
 	tmpPath := fmt.Sprintf("%s.tmp", outputFile)
-	file, err := os.OpenFile(tmpPath, os.O_CREATE|os.O_WRONLY|os.O_TRUNC, 0644)
+	file, err := os.OpenFile(tmpPath, os.O_CREATE|os.O_WRONLY|os.O_TRUNC|os.O_SYNC, 0644)
 	if err != nil {
 		klog.Errorf("error opening file: %v", err)
 		return

Original file line number	Diff line number	Diff line change
`@@ -189,7 +189,7 @@ func trySaveRevision(ctx context.Context, endpoints []string, outputFile string,`
`189`	`189`	`}`
`190`	`190`
`191`	`191`	`tmpPath := fmt.Sprintf("%s.tmp", outputFile)`
`192`		`- file, err := os.OpenFile(tmpPath, os.O_CREATE\|os.O_WRONLY\|os.O_TRUNC, 0644)`
	`192`	`+ file, err := os.OpenFile(tmpPath, os.O_CREATE\|os.O_WRONLY\|os.O_TRUNC\|os.O_SYNC, 0644)`
`193`	`193`	`if err != nil {`
`194`	`194`	`klog.Errorf("error opening file: %v", err)`
`195`	`195`	`return`