OCPBUGS-48400: add bootstrap etcd removal sidecar #1453
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@tjungblu: This pull request references Jira Issue OCPBUGS-48400, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test all |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
tjungblu
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tjungblu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| terminationMessagePolicy: FallbackToLogsOnError | ||
| securityContext: | ||
| privileged: true | ||
| volumeMounts: |
There was a problem hiding this comment.
missing volumeMounts points ?
- name: certs
mountPath: /etc/ssl/etcd/
This newly introduced sidecar will monitor whether the boostrap member was removed by the CEO and remove its own static pod file from the kubelet manifest folder. This ensures that the bootstrap member doesn't come back again or crash loops/restarts during that time. Signed-off-by: Thomas Jungblut <[email protected]>
|
/test e2e-aws-ovn-serial |
|
@tjungblu: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| - name: "ETCDCTL_ENDPOINTS" | ||
| value: "https://localhost:2379" |
There was a problem hiding this comment.
this has a bit of a logical fallacy, because when the member is removed, you won't be able to member list anymore and you won't notice the bootstrap member was removed from the list.
|
I have a draft idea in mind. If you think this is okay, I'll finish it. If not, feel free to close/ignore it, please see openshift/installer#9857
|
|
That's also a sensible approach @lance5890 - we can see what the installer team thanks about openshift/installer#9857 |
3 participants
This newly introduced sidecar will monitor whether the boostrap member was removed by the CEO and remove its own static pod file from the kubelet manifest folder.
This ensures that the bootstrap member doesn't come back again or crash loops/restarts during that time.