IR-295: upgrade to Go 1.19

Author: flavianmissi

.ci-operator.yaml

@@ -1,4 +1,4 @@
 build_root_image:
   name: release
   namespace: openshift
-  tag: rhel-8-release-golang-1.18-openshift-4.12
+  tag: rhel-8-release-golang-1.19-openshift-4.12

Dockerfile

@@ -1,4 +1,4 @@
-FROM registry.ci.openshift.org/ocp/builder:rhel-8-golang-1.18-openshift-4.12 AS builder
+FROM registry.ci.openshift.org/ocp/builder:rhel-8-golang-1.19-openshift-4.12 AS builder
 WORKDIR /go/src/github.com/openshift/cluster-image-registry-operator
 COPY . .
 RUN make build

pkg/client/client.go

@@ -23,7 +23,7 @@ const (
 // GetConfig creates a *rest.Config for talking to a Kubernetes apiserver.
 // Otherwise will assume running in cluster and use the cluster provided kubeconfig.
 //
-// Config precedence
+// # Config precedence
 //
 // * KUBECONFIG environment variable pointing at a file
 //

pkg/resource/generator.go

@@ -118,8 +118,9 @@ func (g *Generator) List(cr *imageregistryv1.Config) ([]Mutator, error) {
 // syncStorage checks:
 // 1.)  to make sure that an existing storage medium still exists and we can access it
 // 2.)  to see if the storage medium name changed and we need to:
-//      a.) check to make sure that we can access the storage or
-//      b.) see if we need to try to create the new storage
+//
+//	a.) check to make sure that we can access the storage or
+//	b.) see if we need to try to create the new storage
 func (g *Generator) syncStorage(cr *imageregistryv1.Config) error {
 	var runCreate bool
 	// Create a driver with the current configuration

pkg/storage/s3/s3.go

@@ -170,14 +170,18 @@ func (d *driver) UpdateEffectiveConfig() error {
 // GetCredentialsFile will create and return the location of an AWS config file that can
 // be used to create AWS clients with. Caller is responsible for cleaning up the file.
 // sharedCredentialsFile, err := d.GetCredentialsFile()
-// if err != nil {
-// 	// handle error
-// }
+//
+//	if err != nil {
+//		// handle error
+//	}
+//
 // defer os.Remove(sharedCredentialsFile)
-// options := session.Options{
-// 	SharedConfigState: session.SharedConfigEnable,
-// 	SharedConfigFiles: []string{sharedCredentialsFile},
-// }
+//
+//	options := session.Options{
+//		SharedConfigState: session.SharedConfigEnable,
+//		SharedConfigFiles: []string{sharedCredentialsFile},
+//	}
+//
 // sess := session.Must(session.NewSessionWithOptions(options))
 func (d *driver) GetCredentialsFile() (string, error) {
 	data, err := d.getCredentialsConfigData()

pkg/storage/storage.go

@@ -160,14 +160,14 @@ func NewDriver(cfg *imageregistryv1.ImageRegistryConfigStorage, kubeconfig *rest
 // replicas for this platform.
 //
 // Following rules apply:
-//  - If it is a known platform for which we have a backend implementation (e.g.
-//    AWS) we return a storage configuration that uses that implementation.
-//  - If it is a known platform and it doesn't provide any backend implementation,
-//    we return an empty storage configuration.
-//  - If it is a unknown platform we return a storage configuration with EmptyDir.
-//    This is useful as it easily allows other teams to experiment with OpenShift
-//    in new platforms, if it is LibVirt platform we also return EmptyDir for
-//    historical reasons.
+//   - If it is a known platform for which we have a backend implementation (e.g.
+//     AWS) we return a storage configuration that uses that implementation.
+//   - If it is a known platform and it doesn't provide any backend implementation,
+//     we return an empty storage configuration.
+//   - If it is a unknown platform we return a storage configuration with EmptyDir.
+//     This is useful as it easily allows other teams to experiment with OpenShift
+//     in new platforms, if it is LibVirt platform we also return EmptyDir for
+//     historical reasons.
 func GetPlatformStorage(listers *regopclient.StorageListers) (imageregistryv1.ImageRegistryConfigStorage, int32, error) {
 	var cfg imageregistryv1.ImageRegistryConfigStorage
 	replicas := int32(1)