Skip to content

Commit 18606a8

Browse files
committed
NE-2008: Add GRPC conformance tests
Add GRPCRoute to the SupportedFeatures list. Increase max time to consistency to 180s for these tests. Increase total run time of test to 20m max. Co-authored-by: Hongan Li <lihongan>
1 parent 81e314f commit 18606a8

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

hack/gatewayapi-conformance.sh

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,10 @@ go mod vendor
5555
# Modify the default timeout of "MaxTimeToConsistency" to make tests pass on AWS
5656
# because the AWS ELB needs an extra ~60s for DNS propagation. See
5757
# <https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/best-practices-dns.html#DNS_change_propagation>.
58-
sed -i -e '/MaxTimeToConsistency:/ s/30/90/' conformance/utils/config/timeout.go
58+
# Also, GRPCRouteListenerHostnameMatching tests are taking longer than 150s to converge to passing.
59+
sed -i -e '/MaxTimeToConsistency:/ s/30/180/' conformance/utils/config/timeout.go
5960

60-
SUPPORTED_FEATURES="Gateway,HTTPRoute,ReferenceGrant,GatewayPort8080,HTTPRouteQueryParamMatching,HTTPRouteMethodMatching,HTTPRouteResponseHeaderModification,HTTPRoutePortRedirect,HTTPRouteSchemeRedirect,HTTPRoutePathRedirect,HTTPRouteHostRewrite,HTTPRoutePathRewrite,HTTPRouteRequestMirror,HTTPRouteRequestMultipleMirrors,HTTPRouteBackendProtocolH2C,HTTPRouteBackendProtocolWebSocket"
61+
SUPPORTED_FEATURES="Gateway,GRPCRoute,HTTPRoute,ReferenceGrant,GatewayPort8080,HTTPRouteQueryParamMatching,HTTPRouteMethodMatching,HTTPRouteResponseHeaderModification,HTTPRoutePortRedirect,HTTPRouteSchemeRedirect,HTTPRoutePathRedirect,HTTPRouteHostRewrite,HTTPRoutePathRewrite,HTTPRouteRequestMirror,HTTPRouteRequestMultipleMirrors,HTTPRouteBackendProtocolH2C,HTTPRouteBackendProtocolWebSocket"
6162

6263
echo "Start Gateway API Conformance Testing"
63-
go test ./conformance -v -timeout 10m -run TestConformance -args "--supported-features=${SUPPORTED_FEATURES}" "--gateway-class=${GATEWAYCLASS_NAME}"
64+
go test ./conformance -v -timeout 20m -run TestConformance -args "--supported-features=${SUPPORTED_FEATURES}" "--gateway-class=${GATEWAYCLASS_NAME}"

0 commit comments

Comments
 (0)