Skip to content

Commit 288f96c

Browse files
Merge pull request #1202 from alebedev87/ne-1969-versioned-controllername
NE-1969: Add "v1" version to OpenShift GatewayClass controller name
2 parents 1b72b75 + 1c7a295 commit 288f96c

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

hack/gatewayapi-conformance.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ kind: GatewayClass
2020
metadata:
2121
name: conformance
2222
spec:
23-
controllerName: openshift.io/gateway-controller
23+
controllerName: openshift.io/gateway-controller/v1
2424
EOF
2525

2626
oc wait --for=condition=Accepted=true "gatewayclass/$GATEWAYCLASS_NAME" --timeout=300s

pkg/operator/controller/names.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ const (
6262
// gatewayclass identifies itself as belonging to OpenShift Istio. If a
6363
// gatewayclass's spec.controllerName field is set to this value, then
6464
// the gatewayclass is ours.
65-
OpenShiftGatewayClassControllerName = "openshift.io/gateway-controller"
65+
OpenShiftGatewayClassControllerName = "openshift.io/gateway-controller/v1"
6666

6767
// OpenShiftDefaultGatewayClassName is the name of the default
6868
// gatewayclass that Istio creates when it is installed.

0 commit comments

Comments
 (0)