Skip to content

Commit 5c30510

Browse files
committed
TestGatewayAPI: Remove t.Helper() from subtests
This commit ensures that test failure reports point to the exact subtest.
1 parent 70d00ff commit 5c30510

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

test/e2e/gateway_api_test.go

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,6 @@ func TestGatewayAPI(t *testing.T) {
109109
// CRDs are created.
110110
// It also deletes and ensure the CRDs are recreated.
111111
func testGatewayAPIResources(t *testing.T) {
112-
t.Helper()
113112
// Make sure all the *.gateway.networking.k8s.io CRDs are available since the FeatureGate is enabled.
114113
ensureCRDs(t)
115114

@@ -128,8 +127,6 @@ func testGatewayAPIResources(t *testing.T) {
128127
// - the SMCP is created successfully (OSSM 2.x).
129128
// - deletes SMCP and subscription and tests if it gets recreated
130129
func testGatewayAPIIstioInstallation(t *testing.T) {
131-
t.Helper()
132-
133130
if err := assertSubscription(t, openshiftOperatorsNamespace, expectedSubscriptionName); err != nil {
134131
t.Fatalf("failed to find expected Subscription %s: %v", expectedSubscriptionName, err)
135132
}
@@ -166,8 +163,6 @@ func testGatewayAPIIstioInstallation(t *testing.T) {
166163

167164
// testGatewayAPIObjects tests that Gateway API objects can be created successfully.
168165
func testGatewayAPIObjects(t *testing.T) {
169-
t.Helper()
170-
171166
// Create a test namespace that cleans itself up and sets up its own service account and role binding.
172167
ns := createNamespace(t, names.SimpleNameGenerator.GenerateName("test-e2e-gwapi-"))
173168

@@ -189,8 +184,6 @@ func testGatewayAPIObjects(t *testing.T) {
189184
// denies admission requests attempting to modify Gateway API CRDs on behalf of a user
190185
// who is not the ingress operator's service account.
191186
func testGatewayAPIResourcesProtection(t *testing.T) {
192-
t.Helper()
193-
194187
// Get kube client which impersonates ingress operator's service account.
195188
kubeConfig, err := config.GetConfig()
196189
if err != nil {

0 commit comments

Comments
 (0)