Skip to content

Commit 8055a97

Browse files
committed
gatewayapi-conformance.sh: Shorten gatewayclass
Shorten the name of the gatewayclass that the conformance tests use in order to avoid errors creating the service, which is named based on the gateway's and gatewayclasses's names: Invalid value: "http-listener-isolation-with-hostname-intersection-gateway-conformance": must be no more than 63 characters This failure is from the GatewayHTTPListenerIsolation test. We do not currently run this test by default. This commit shortens the gatewayclass name in preparation for enabling the test in the future. * hack/gatewayapi-conformance.sh: Shorten the gatewayclass name.
1 parent 82d119f commit 8055a97

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

hack/gatewayapi-conformance.sh

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,17 +11,19 @@ if [[ "${BUNDLE_VERSION}" == "null" ]]; then
1111
fi
1212
echo "Gateway API CRD bundle-version: ${BUNDLE_VERSION}"
1313

14-
echo "Create GatewayClass gateway-conformance"
14+
GATEWAYCLASS_NAME=conformance
15+
16+
echo "Create GatewayClass \"${GATEWAYCLASS_NAME}\""
1517
oc apply -f -<<EOF
1618
apiVersion: gateway.networking.k8s.io/v1
1719
kind: GatewayClass
1820
metadata:
19-
name: gateway-conformance
21+
name: conformance
2022
spec:
2123
controllerName: openshift.io/gateway-controller
2224
EOF
2325

24-
oc wait --for=condition=Accepted=true gatewayclass/gateway-conformance --timeout=300s
26+
oc wait --for=condition=Accepted=true "gatewayclass/$GATEWAYCLASS_NAME" --timeout=300s
2527

2628
echo "All gatewayclass status:"
2729
oc get gatewayclass -A
@@ -58,4 +60,4 @@ sed -i -e '/MaxTimeToConsistency:/ s/30/90/' conformance/utils/config/timeout.go
5860
SUPPORTED_FEATURES="Gateway,HTTPRoute,ReferenceGrant,GatewayPort8080,HTTPRouteQueryParamMatching,HTTPRouteMethodMatching,HTTPRouteResponseHeaderModification,HTTPRoutePortRedirect,HTTPRouteSchemeRedirect,HTTPRoutePathRedirect,HTTPRouteHostRewrite,HTTPRoutePathRewrite,HTTPRouteRequestMirror,HTTPRouteRequestMultipleMirrors,HTTPRouteBackendProtocolH2C,HTTPRouteBackendProtocolWebSocket"
5961

6062
echo "Start Gateway API Conformance Testing"
61-
go test ./conformance -v -timeout 10m -run TestConformance -args "--supported-features=${SUPPORTED_FEATURES}"
63+
go test ./conformance -v -timeout 10m -run TestConformance -args "--supported-features=${SUPPORTED_FEATURES}" "--gateway-class=${GATEWAYCLASS_NAME}"

0 commit comments

Comments
 (0)