Skip to content

Commit a2d994d

Browse files
committed
gateway_api_test: Delete t.Helper() from tests
Delete t.Helper() from Gateway API test. These are tests, not helpers, and using t.Helper() obscures the actual location of a failure within a test. * test/e2e/gateway_api_test.go (testGatewayAPIResources) (testGatewayAPIIstioInstallation, testGatewayAPIObjects): Delete t.Helper().
1 parent 4547ab4 commit a2d994d

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

test/e2e/gateway_api_test.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ func TestGatewayAPI(t *testing.T) {
8282
// CRDs are created.
8383
// It also deletes and ensure the CRDs are recreated.
8484
func testGatewayAPIResources(t *testing.T) {
85-
t.Helper()
8685
// Make sure all the *.gateway.networking.k8s.io CRDs are available since the FeatureGate is enabled.
8786
ensureCRDs(t)
8887

@@ -109,8 +108,6 @@ func testGatewayAPIResources(t *testing.T) {
109108
// - If the Istio and Subscription CRs are deleted, they are recreated
110109
// automatically.
111110
func testGatewayAPIIstioInstallation(t *testing.T) {
112-
t.Helper()
113-
114111
t.Log("Checking for the Subscription...")
115112
if err := assertSubscription(t, openshiftOperatorsNamespace, expectedSubscriptionName); err != nil {
116113
t.Fatalf("failed to find expected Subscription %s: %v", expectedSubscriptionName, err)
@@ -151,8 +148,6 @@ func testGatewayAPIIstioInstallation(t *testing.T) {
151148

152149
// testGatewayAPIObjects tests that Gateway API objects can be created successfully.
153150
func testGatewayAPIObjects(t *testing.T) {
154-
t.Helper()
155-
156151
// Create a test namespace that cleans itself up and sets up its own service account and role binding.
157152
ns := createNamespace(t, names.SimpleNameGenerator.GenerateName("test-e2e-gwapi-"))
158153

0 commit comments

Comments
 (0)